Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for ICAT 5 Mappings #310

Open
1 task
MRichards99 opened this issue Jan 31, 2022 · 1 comment
Open
1 task

Tests for ICAT 5 Mappings #310

MRichards99 opened this issue Jan 31, 2022 · 1 comment
Labels
expands-search-api Issues relating to the ExPaNDS Search API section of this repo

Comments

@MRichards99
Copy link
Collaborator

Description:

While writing the endpoint tests, I've skipped some of them that rely on ICAT 5 mappings. When ICAT 5 is released, we should unskip these tests, but only if the ICAT version is less than 5. We can get the version number through the client class. This might also be relevant for the tests on the mappings too.

Acceptance criteria:

  • Detect ICAT Server version and skip certain tests if they require ICAT 5 to pass
@MRichards99 MRichards99 added the expands-search-api Issues relating to the ExPaNDS Search API section of this repo label Jan 31, 2022
@MRichards99
Copy link
Collaborator Author

For the tests to work, there will need to be test data added to the generator script for the new entities meaning the new entities will need to be added to the DB backend. Is it easier to rewrite the generator script using Python ICAT at this point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expands-search-api Issues relating to the ExPaNDS Search API section of this repo
Projects
None yet
Development

No branches or pull requests

1 participant