Refactor CatalogueCategoryPropertyService unit tests #376 #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #379 +/- ##
========================================
Coverage 97.86% 97.86%
========================================
Files 41 41
Lines 1502 1502
========================================
Hits 1470 1470
Misses 32 32 ☔ View full report in Codecov by Sentry. |
joelvdavies
changed the title
joelvdavies
force-pushed
the
refactor-catalogue-category-property-service-unit-tests-#376
branch
from
7314573 to
2f35aa9
Compare
Yes, they should be. |
VKTB
approved these changes
Sep 18, 2024
Created an issue #381. |
joelvdavies
deleted the
refactor-catalogue-category-property-service-unit-tests-#376
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #376.
Notes
test_create_with_non_leaf_catalogue_categorywhereas the properties service is currently using InvalidActionError, should these be unified?Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #376