Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate replacing cssInjectedByJsPlugin? #1086

Open
joelvdavies opened this issue Oct 22, 2024 · 0 comments
Open

Investigate replacing cssInjectedByJsPlugin? #1086

joelvdavies opened this issue Oct 22, 2024 · 0 comments
Labels
enhancement Improved or refactored feature question Further information is requested

Comments

@joelvdavies
Copy link
Collaborator

It will not be compatible with ESM if we move to it in the future. For context this was added to get uppy styles to import when loading in scigateway, so removing it from the build breaks it. Manually adding a works correctly.

Potential useful info includes:

Likely requires SciGateway changes to single-spa.

@joelvdavies joelvdavies added enhancement Improved or refactored feature question Further information is requested labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improved or refactored feature question Further information is requested
Projects
Status: Backlog
Development

No branches or pull requests

1 participant