Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an endpoint for deleting an image #38

Open
3 tasks done
joelvdavies opened this issue Oct 7, 2024 · 0 comments · May be fixed by #72
Open
3 tasks done

Add an endpoint for deleting an image #38

joelvdavies opened this issue Oct 7, 2024 · 0 comments · May be fixed by #72
Assignees
@asuresh-code
Labels
enhancement New feature or request

Comments

@joelvdavies
Copy link
Collaborator

joelvdavies commented Oct 7, 2024 •
edited
Loading

Implement a DELETE endpoint /images/<image_id> that:

  • Deletes the image metadata from the database
  • Deletes the file object in the object store
  • Must gracefully deal with a situation when the file object with the given object_key doesn't exist
@joelvdavies joelvdavies added the enhancement New feature or request label Oct 7, 2024
@joelvdavies joelvdavies mentioned this issue Oct 22, 2024
Open
asuresh-code added a commit that referenced this issue Oct 29, 2024
@asuresh-code
implement filter functionality TODO: check if exceptions are required…
dd87490 
… and write tests #38
@asuresh-code asuresh-code mentioned this issue Oct 29, 2024
Merged
6 tasks
asuresh-code added a commit that referenced this issue Oct 29, 2024
@asuresh-code
add fixture to conftest #38
7885b45
@joelvdavies joelvdavies moved this from Backlog to Up Next in Inventory Management System Nov 25, 2024
asuresh-code added a commit that referenced this issue Nov 27, 2024
@asuresh-code
create delete endpoint TODO: add docstring comments and testing #38
23626f8
asuresh-code added a commit that referenced this issue Nov 28, 2024
@asuresh-code
Implement unit repo tests #38
ffa38cc
@asuresh-code asuresh-code linked a pull request Nov 28, 2024 that will close this issue
Open
3 tasks
asuresh-code added a commit that referenced this issue Nov 28, 2024
@asuresh-code
implement rest of testing TODO: add docstrings + get_image check on e…
72c2255 
…2e test #38
asuresh-code added a commit that referenced this issue Nov 29, 2024
@asuresh-code
add documentation to methods TODO: add get check to delete e2e test #38
b103702
asuresh-code added a commit that referenced this issue Dec 4, 2024
@asuresh-code
Address PR Review Comments TODO: Wait for GET endpoint to merge, test…
fd26b54 
…s will fail till then #38
@asuresh-code asuresh-code moved this from Up Next to In Progress in Inventory Management System Dec 4, 2024
@asuresh-code asuresh-code moved this from In Progress to In Review in Inventory Management System Dec 4, 2024
asuresh-code added a commit that referenced this issue Dec 5, 2024
@asuresh-code
Merge remote-tracking branch 'origin/develop' into add-delete-endpoin…
5372b7d 
…t-for-image-#38
asuresh-code added a commit that referenced this issue Dec 5, 2024
@asuresh-code
add get check to delete e2e test and minor changes #38
60ab20a
asuresh-code added a commit that referenced this issue Dec 6, 2024
@asuresh-code
Address PR Review comments #38
c360d4a
asuresh-code added a commit that referenced this issue Dec 6, 2024
@asuresh-code
Address PR Review Comments #38
094fb83
asuresh-code added a commit that referenced this issue Dec 9, 2024
@asuresh-code
change order of service test assertion #38
e4ec480
@joelvdavies joelvdavies mentioned this issue Dec 9, 2024
Open
2 tasks
asuresh-code added a commit that referenced this issue Dec 13, 2024
@asuresh-code
Address PR Review comments #38
03f6736
asuresh-code added a commit that referenced this issue Dec 13, 2024
@asuresh-code
Merge branch 'develop' into add-delete-endpoint-for-image-#38
8e33467
asuresh-code added a commit that referenced this issue Dec 13, 2024
@asuresh-code
address linting issues #38
ce62423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asuresh-code asuresh-code

Labels
enhancement New feature or request
Projects
Inventory Management System
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add delete endpoint for image ral-facilities/object-storage-api
2 participants
@asuresh-code @joelvdavies