You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description: @VKTB pointed out that currently, any refresh token can refresh any access token, so if a user with a valid refresh token got someone else's access token, they could refresh it and be given a new valid access token with the other user's credentials. We should put the user's username in the refresh token, and then do a check in the refresh endpoint to check if the refresh token's username matches the access token's username before issuing a new access token.
Acceptance criteria:
Username is in the payload of a refresh token
Refresh tokens can only refresh access tokens which match their username
The text was updated successfully, but these errors were encountered:
Description:
@VKTB pointed out that currently, any refresh token can refresh any access token, so if a user with a valid refresh token got someone else's access token, they could refresh it and be given a new valid access token with the other user's credentials. We should put the user's username in the refresh token, and then do a check in the refresh endpoint to check if the refresh token's username matches the access token's username before issuing a new access token.
Acceptance criteria:
The text was updated successfully, but these errors were encountered: