Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insufficient allocate in SSIDS C interface #199

Merged

Conversation

jfowkes
Copy link
Contributor

@jfowkes jfowkes commented Jun 5, 2024

Resolves #198 (see the linked issue for details)

@jfowkes jfowkes linked an issue Jun 5, 2024 that may be closed by this pull request
@jfowkes jfowkes self-assigned this Jun 5, 2024
@jfowkes
Copy link
Contributor Author

jfowkes commented Jun 5, 2024

@chrhansk please test the proposed fix, if this works for you I will merge into master.

@mjacobse
Copy link
Collaborator

mjacobse commented Jun 5, 2024

The ptr32 version here

allocate(frow_alloc(fakeep%n+1))
should probably also be fixed.

@jfowkes
Copy link
Contributor Author

jfowkes commented Jun 5, 2024

Good spot @mjacobse! Will add that now...

@jfowkes jfowkes requested a review from mjacobse June 5, 2024 08:41
@chrhansk
Copy link
Contributor

chrhansk commented Jun 5, 2024

@jfowkes: Does fix the problem for me, looks good.

@jfowkes jfowkes merged commit c558d18 into master Jun 5, 2024
16 checks passed
@jfowkes jfowkes deleted the 198-insufficient-memory-allocation-in-ssids-c-interface branch June 5, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insufficient memory allocation in SSIDS C interface
3 participants