Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change trigger to pull_request_target #1889

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Dec 14, 2023

pull_request_target has write access to the target repository even when triggered from a 3rd party fork.

This is safe since we do not checkout any code and only run the workflow after closing the PR.

pull_request_target has write access to the target repository even when
triggered from a 3rd party fork.

This is safe since we do not checkout any code and only run the workflow
after closing the PR.

Signed-off-by: Fredrik Lönnegren <[email protected]>
@frelon frelon requested a review from a team as a code owner December 14, 2023 16:14
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frelon frelon enabled auto-merge (squash) December 14, 2023 16:22
@frelon frelon merged commit af937bb into rancher:main Dec 14, 2023
14 checks passed
@frelon frelon deleted the cache-cleanup3 branch December 14, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants