Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.31] Bump crictl #6976

Closed
cwayne18 opened this issue Oct 9, 2024 · 4 comments
Closed

[Release 1.31] Bump crictl #6976

cwayne18 opened this issue Oct 9, 2024 · 4 comments
Assignees

Comments

@cwayne18
Copy link
Member

cwayne18 commented Oct 9, 2024

Bump to 1.31.1-build20241008

@cwayne18 cwayne18 added this to the 2024-10 Release Cycle milestone Oct 10, 2024
@aganesh-suse aganesh-suse self-assigned this Oct 10, 2024
@brandond brandond self-assigned this Oct 10, 2024
@aganesh-suse
Copy link

aganesh-suse commented Oct 10, 2024

Issue: Getting crictl version unknown.
Expected result: Display the correct crictl version

OS: Ubuntu 24.04

Branch: release-1.31
Commit ID: a70094f

$ rke2 -v
rke2 version v1.31.1+dev.a70094f7 (a70094f7f64b95192f7bf0b4a282c4007b6c8b12)
go version go1.22.6 X:boringcrypto
$ crictl -v
crictl version unknown

Note: This works till the (previous) commit id: d6b0aeb

$ rke2 -v
rke2 version v1.31.1+dev.d6b0aeb0 (d6b0aeb0a16d66cdf3ddf822c08e9921ea111a00)
go version go1.22.6 X:boringcrypto
$ crictl -v
crictl version v1.30.1

@brandond
Copy link
Member

I suspect rancher/image-build-crictl#40 made the repo dirty and broke whatever logic the upstream build script was using to set the version. I can fix that and rebuild/update.

@brandond
Copy link
Member

The package has changed for cri-tools v1.31: kubernetes-sigs/cri-tools@3f6ce81

@ShylajaDevadiga
Copy link
Contributor

Validated fix the latest commit on release-1.31 branch.

ubuntu@ip-172-31-1-149:~$ rke2 -v
rke2 version v1.31.1+dev.cc064cab (cc064cab2d601a777e0a75bc2602068f799fceb8)
go version go1.22.6 X:boringcrypto
ubuntu@ip-172-31-1-149:~$ crictl -v
crictl version v1.31.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants