Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property repeats #36

Open
cbizon opened this issue Nov 14, 2020 · 2 comments
Open

Property repeats #36

cbizon opened this issue Nov 14, 2020 · 2 comments

Comments

@cbizon
Copy link
Contributor

cbizon commented Nov 14, 2020

Run X-treats->schizophrenia through strider, omnicorp, and ranker, then send to property coalesce.

We find multiple coalsescences on the same exact properties. i.e. sets of two nodes are picked out, and then a different set of 2 nodes is picked out with the same properties.

My current guess is that the omnicorp edges are interfering with the coalescent opportunities, but I have not tested that.

Probably, we should ignore support edges in coalescing.

@cbizon cbizon self-assigned this Nov 14, 2020
@cbizon
Copy link
Contributor Author

cbizon commented Nov 16, 2020

Confirmed that removing the omnicorp edges from the graph before sending to AC solves this problem.

@cbizon
Copy link
Contributor Author

cbizon commented Jun 21, 2021

Omnicorp now happens after AC in aragorn. However, we might still want some logic about which edges to worry about / exclude since operations/workflow may lead to situations in which this re-occurs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant