Add ability to modify and propagate names of columns object
#17597
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/okay to test |
galipremsagar
added
improvement
|
/okay to test |
galipremsagar
added
bug
| @@ -207,11 +207,16 @@ def _from_columns_like_self( | |||
|
|
|||
| @property | |||
| def level_names(self) -> tuple[abc.Hashable, ...]: | |||
| if self.is_cached("to_pandas_index"): | |||
| return self.to_pandas_index.names | |||
There was a problem hiding this comment.
Is there any particular reason we want/need to use the cached to_pandas_index here?
There was a problem hiding this comment.
Yes, when updates to the pandas object created by to_pandas_index are performed, we need the updated names, that's what this piece of code does.
|
I think this may close #14012 too |
Co-authored-by: Matthew Roeschke <[email protected]>
There was a problem hiding this comment.
Just https://github.com/rapidsai/cudf/pull/17597/files#r1887795031 otherwise LGTM
Co-authored-by: Matthew Roeschke <[email protected]>
Done 👍 Sorry that slipped my radar. |
galipremsagar
added
the
5 - Ready to Merge
|
/merge |
Description
Fixes: #17482, #14012
This PR fixes a long-standing issue where modifying
columnsnamenever propagates to the parent object. This PR fixes this issue by makingto_pandas_indexa cached-property and accessing it's names if this property was ever invoked inlevel_namesproperty.Checklist