From a81f016f6e49874de87202fc9756b1649ab801ae Mon Sep 17 00:00:00 2001 From: James Lamb Date: Thu, 30 May 2024 10:38:33 -0500 Subject: [PATCH] remove unnecessary 'setuptools' dependencies (#1389) Contributes to https://github.com/rapidsai/build-planning/issues/62. It looks like this project's wheels and conda recipes have unnecessary dependencies on `setuptools`. I suspect those are left over from before the project was cut over to `scikit-build-core`. This proposes removing those. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Mark Harris (https://github.com/harrism) - Jake Awe (https://github.com/AyodeAwe) URL: https://github.com/rapidsai/cuspatial/pull/1389 --- conda/recipes/cuproj/meta.yaml | 1 - conda/recipes/cuspatial/meta.yaml | 1 - dependencies.yaml | 1 - python/cuproj/pyproject.toml | 1 - python/cuspatial/pyproject.toml | 1 - 5 files changed, 5 deletions(-) diff --git a/conda/recipes/cuproj/meta.yaml b/conda/recipes/cuproj/meta.yaml index 4721daefb..d65a983c6 100644 --- a/conda/recipes/cuproj/meta.yaml +++ b/conda/recipes/cuproj/meta.yaml @@ -63,7 +63,6 @@ requirements: - python - rmm ={{ minor_version }} - scikit-build-core >=0.7.0 - - setuptools - proj - sqlite run: diff --git a/conda/recipes/cuspatial/meta.yaml b/conda/recipes/cuspatial/meta.yaml index 1bc68677f..b3ea40cb7 100644 --- a/conda/recipes/cuspatial/meta.yaml +++ b/conda/recipes/cuspatial/meta.yaml @@ -65,7 +65,6 @@ requirements: - python - rmm ={{ minor_version }} - scikit-build-core >=0.7.0 - - setuptools run: {% if cuda_major == "11" %} - cudatoolkit diff --git a/dependencies.yaml b/dependencies.yaml index fa7b82381..7fe3fa2f6 100644 --- a/dependencies.yaml +++ b/dependencies.yaml @@ -232,7 +232,6 @@ dependencies: - output_types: [requirements, pyproject] packages: - wheel - - setuptools cuda_version: specific: - output_types: conda diff --git a/python/cuproj/pyproject.toml b/python/cuproj/pyproject.toml index 88066054f..8392dc75f 100644 --- a/python/cuproj/pyproject.toml +++ b/python/cuproj/pyproject.toml @@ -20,7 +20,6 @@ requires = [ "ninja", "rmm==24.8.*", "scikit-build-core[pyproject]>=0.7.0", - "setuptools", "wheel", ] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`. diff --git a/python/cuspatial/pyproject.toml b/python/cuspatial/pyproject.toml index d174f8689..b2d6eddbd 100644 --- a/python/cuspatial/pyproject.toml +++ b/python/cuspatial/pyproject.toml @@ -21,7 +21,6 @@ requires = [ "ninja", "rmm==24.8.*", "scikit-build-core[pyproject]>=0.7.0", - "setuptools", "wheel", ] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.