diff --git a/ci/build_cpp.sh b/ci/build_cpp.sh index db4c496cc..d5047a405 100755 --- a/ci/build_cpp.sh +++ b/ci/build_cpp.sh @@ -17,7 +17,11 @@ rapids-logger "Begin cpp build" sccache --zero-stats -RAPIDS_PACKAGE_VERSION=$(rapids-generate-version) rapids-conda-retry mambabuild conda/recipes/libcuvs +LIBRAFT_CHANNEL=$(rapids-get-pr-conda-artifact raft 2530 cpp) + +RAPIDS_PACKAGE_VERSION=$(rapids-generate-version) rapids-conda-retry mambabuild \ + --channel "${LIBRAFT_CHANNEL}" \ + conda/recipes/libcuvs sccache --show-adv-stats diff --git a/ci/build_python.sh b/ci/build_python.sh index 3241a2c2b..95058647b 100755 --- a/ci/build_python.sh +++ b/ci/build_python.sh @@ -19,6 +19,7 @@ package_name="cuvs" package_dir="python" CPP_CHANNEL=$(rapids-download-conda-from-s3 cpp) +LIBRAFT_CHANNEL=$(rapids-get-pr-conda-artifact raft 2530 cpp) version=$(rapids-generate-version) export RAPIDS_PACKAGE_VERSION=${version} @@ -31,6 +32,7 @@ sccache --zero-stats rapids-conda-retry mambabuild \ --no-test \ --channel "${CPP_CHANNEL}" \ + --channel "${LIBRAFT_CHANNEL}" \ conda/recipes/cuvs sccache --show-adv-stats @@ -40,6 +42,7 @@ sccache --zero-stats rapids-conda-retry mambabuild \ --no-test \ --channel "${CPP_CHANNEL}" \ + --channel "${LIBRAFT_CHANNEL}" \ --channel "${RAPIDS_CONDA_BLD_OUTPUT_DIR}" \ conda/recipes/cuvs-bench @@ -53,6 +56,7 @@ if [[ ${RAPIDS_CUDA_MAJOR} == "12" ]]; then rapids-conda-retry mambabuild \ --no-test \ --channel "${CPP_CHANNEL}" \ + --channel "${LIBRAFT_CHANNEL}" \ --channel "${RAPIDS_CONDA_BLD_OUTPUT_DIR}" \ conda/recipes/cuvs-bench-cpu diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt index 79e50c1c1..26c0b82d3 100644 --- a/cpp/CMakeLists.txt +++ b/cpp/CMakeLists.txt @@ -486,13 +486,14 @@ if(BUILD_SHARED_LIBS) "$<$:${CUVS_CUDA_FLAGS}>" ) target_link_libraries( - cuvs_objs PUBLIC raft::raft rmm::rmm rmm::rmm_logger ${CUVS_CTK_MATH_DEPENDENCIES} - $ - PRIVATE rmm::rmm_logger_impl + cuvs_objs + PUBLIC raft::raft rmm::rmm rmm::rmm_logger ${CUVS_CTK_MATH_DEPENDENCIES} + $ + PRIVATE rmm::rmm_logger_impl raft::raft_logger_impl ) add_library(cuvs SHARED $,EXCLUDE,rmm.*logger>) - add_library(cuvs_static STATIC $,EXCLUDE,rmm.*logger>) + add_library(cuvs_static STATIC $,EXCLUDE,rmm.*logger>) target_compile_options( cuvs INTERFACE $<$:--expt-extended-lambda @@ -704,7 +705,7 @@ target_compile_definitions(cuvs::cuvs INTERFACE $<$:NVTX_ENAB target_link_libraries( cuvs_c PUBLIC cuvs::cuvs ${CUVS_CTK_MATH_DEPENDENCIES} - PRIVATE raft::raft rmm::rmm_logger_impl + PRIVATE raft::raft rmm::rmm_logger_impl raft::raft_logger_impl ) # ensure CUDA symbols aren't relocated to the middle of the debug build binaries diff --git a/cpp/bench/ann/CMakeLists.txt b/cpp/bench/ann/CMakeLists.txt index 144cd3048..200b52ab3 100644 --- a/cpp/bench/ann/CMakeLists.txt +++ b/cpp/bench/ann/CMakeLists.txt @@ -126,10 +126,11 @@ function(ConfigureAnnBench) PRIVATE ${ConfigureAnnBench_LINKS} nlohmann_json::nlohmann_json Threads::Threads + $ $<$:CUDA::cudart_static> $ $ - $ + $ ) set_target_properties( @@ -175,9 +176,11 @@ function(ConfigureAnnBench) add_dependencies(CUVS_ANN_BENCH_ALL ${BENCH_NAME}) endfunction() -if(CUVS_FAISS_ENABLE_GPU) - add_library(cuvs_bench_rmm_logger OBJECT) - target_link_libraries(cuvs_bench_rmm_logger PRIVATE rmm::rmm_logger_impl) +if(CUVS_FAISS_ENABLE_GPU OR CUVS_ANN_BENCH_SINGLE_EXE) + add_library(cuvs_bench_logger OBJECT) + target_link_libraries( + cuvs_bench_logger PRIVATE rmm::rmm_logger_impl $ + ) endif() # ################################################################################################## @@ -303,8 +306,14 @@ if(CUVS_ANN_BENCH_SINGLE_EXE) target_link_libraries( ANN_BENCH - PRIVATE raft::raft nlohmann_json::nlohmann_json benchmark::benchmark dl fmt::fmt-header-only - spdlog::spdlog_header_only $<$:CUDA::nvtx3> rmm::rmm_logger_impl + PRIVATE raft::raft + nlohmann_json::nlohmann_json + benchmark::benchmark + dl + fmt::fmt-header-only + spdlog::spdlog_header_only + $<$:CUDA::nvtx3> + cuvs_bench_logger ) set_target_properties( ANN_BENCH diff --git a/cpp/bench/ann/src/common/benchmark.hpp b/cpp/bench/ann/src/common/benchmark.hpp index 06e1e27af..49be78673 100644 --- a/cpp/bench/ann/src/common/benchmark.hpp +++ b/cpp/bench/ann/src/common/benchmark.hpp @@ -597,18 +597,16 @@ inline auto parse_string_flag(const char* arg, const char* pat, std::string& res inline auto run_main(int argc, char** argv) -> int { - bool force_overwrite = false; - bool build_mode = false; - bool search_mode = false; - bool no_lap_sync = false; - std::string data_prefix = "data"; - std::string index_prefix = "index"; - std::string new_override_kv = ""; - std::string mode = "latency"; - std::string threads_arg_txt = ""; - std::vector threads = {1, -1}; // min_thread, max_thread - std::string log_level_str = ""; - [[maybe_unused]] int raft_log_level = 0; // raft::logger::get(RAFT_NAME).get_level(); + bool force_overwrite = false; + bool build_mode = false; + bool search_mode = false; + bool no_lap_sync = false; + std::string data_prefix = "data"; + std::string index_prefix = "index"; + std::string new_override_kv = ""; + std::string mode = "latency"; + std::string threads_arg_txt = ""; + std::vector threads = {1, -1}; // min_thread, max_thread kv_series override_kv{}; char arg0_default[] = "benchmark"; // NOLINT @@ -639,12 +637,7 @@ inline auto run_main(int argc, char** argv) -> int parse_string_flag(argv[i], "--index_prefix", index_prefix) || parse_string_flag(argv[i], "--mode", mode) || parse_string_flag(argv[i], "--override_kv", new_override_kv) || - parse_string_flag(argv[i], "--threads", threads_arg_txt) || - parse_string_flag(argv[i], "--raft_log_level", log_level_str)) { - if (!log_level_str.empty()) { - raft_log_level = std::stoi(log_level_str); - log_level_str = ""; - } + parse_string_flag(argv[i], "--threads", threads_arg_txt)) { if (!threads_arg_txt.empty()) { auto threads_arg = split(threads_arg_txt, ':'); threads[0] = std::stoi(threads_arg[0]); @@ -673,8 +666,6 @@ inline auto run_main(int argc, char** argv) -> int } } - // raft::logger::get(RAFT_NAME).set_level(raft_log_level); - Mode metric_objective = Mode::kLatency; if (mode == "throughput") { metric_objective = Mode::kThroughput; } diff --git a/cpp/cmake/thirdparty/get_raft.cmake b/cpp/cmake/thirdparty/get_raft.cmake index 5def74f4b..2720579f6 100644 --- a/cpp/cmake/thirdparty/get_raft.cmake +++ b/cpp/cmake/thirdparty/get_raft.cmake @@ -13,8 +13,8 @@ # Use RAPIDS_VERSION_MAJOR_MINOR from rapids_config.cmake set(RAFT_VERSION "${RAPIDS_VERSION_MAJOR_MINOR}") -set(RAFT_FORK "rapidsai") -set(RAFT_PINNED_TAG "branch-${RAPIDS_VERSION_MAJOR_MINOR}") +set(RAFT_FORK "vyasr") +set(RAFT_PINNED_TAG "feat/logger") function(find_and_configure_raft) set(oneValueArgs VERSION FORK PINNED_TAG USE_RAFT_STATIC ENABLE_NVTX ENABLE_MNMG_DEPENDENCIES CLONE_ON_PIN) @@ -68,6 +68,6 @@ find_and_configure_raft(VERSION ${RAFT_VERSION}.00 # When PINNED_TAG above doesn't match the default rapids branch, # force local raft clone in build directory # even if it's already installed. - CLONE_ON_PIN ${CUVS_RAFT_CLONE_ON_PIN} + CLONE_ON_PIN OFF ) diff --git a/cpp/include/cuvs/cluster/kmeans.hpp b/cpp/include/cuvs/cluster/kmeans.hpp index 89b3acc24..cb8d36b10 100644 --- a/cpp/include/cuvs/cluster/kmeans.hpp +++ b/cpp/include/cuvs/cluster/kmeans.hpp @@ -17,6 +17,7 @@ #include #include #include +#include #include #include @@ -85,7 +86,7 @@ struct params : base_params { /** * verbosity level. */ - int verbosity = RAFT_LEVEL_INFO; + raft::level_enum verbosity = raft::level_enum::info; /** * Seed to the random number generator. diff --git a/cpp/src/cluster/detail/kmeans.cuh b/cpp/src/cluster/detail/kmeans.cuh index 3d054f0fd..e943b8afc 100644 --- a/cpp/src/cluster/detail/kmeans.cuh +++ b/cpp/src/cluster/detail/kmeans.cuh @@ -25,7 +25,7 @@ #include #include #include -#include +#include #include #include #include @@ -56,8 +56,6 @@ namespace cuvs::cluster::kmeans::detail { -// TODO(cjnolet): RAFT_NAME needs to be removed and the raft::logger fixed to not require it -static const std::string RAFT_NAME = "raft"; static const std::string CUVS_NAME = "cuvs"; // ========================================================= @@ -373,7 +371,7 @@ void kmeans_fit_main(raft::resources const& handle, rmm::device_uvector& workspace) { raft::common::nvtx::range fun_scope("kmeans_fit_main"); - raft::logger::get(RAFT_NAME).set_level(params.verbosity); + raft::default_logger().set_level(params.verbosity); cudaStream_t stream = raft::resource::get_cuda_stream(handle); auto n_samples = X.extent(0); auto n_features = X.extent(1); @@ -879,7 +877,7 @@ void kmeans_fit(raft::resources const& handle, pams.n_clusters); } - raft::logger::get(RAFT_NAME).set_level(pams.verbosity); + raft::default_logger().set_level(pams.verbosity); // Allocate memory rmm::device_uvector workspace(0, stream); @@ -1025,7 +1023,7 @@ void kmeans_predict(raft::resources const& handle, RAFT_EXPECTS(centroids.extent(1) == n_features, "invalid parameter (centroids.extent(1) != n_features)"); - raft::logger::get(RAFT_NAME).set_level(pams.verbosity); + raft::default_logger().set_level(pams.verbosity); auto metric = pams.metric; // Allocate memory @@ -1218,7 +1216,7 @@ void kmeans_transform(raft::resources const& handle, raft::device_matrix_view X_new) { raft::common::nvtx::range fun_scope("kmeans_transform"); - raft::logger::get(RAFT_NAME).set_level(pams.verbosity); + raft::default_logger().set_level(pams.verbosity); cudaStream_t stream = raft::resource::get_cuda_stream(handle); auto n_samples = X.extent(0); auto n_features = X.extent(1); diff --git a/cpp/src/cluster/detail/kmeans_auto_find_k.cuh b/cpp/src/cluster/detail/kmeans_auto_find_k.cuh index 6441f7ad5..797b33bca 100644 --- a/cpp/src/cluster/detail/kmeans_auto_find_k.cuh +++ b/cpp/src/cluster/detail/kmeans_auto_find_k.cuh @@ -21,7 +21,7 @@ #include #include #include -#include +#include #include #include #include @@ -230,4 +230,4 @@ void find_k(raft::resources const& handle, n_iter); } } -} // namespace cuvs::cluster::kmeans::detail \ No newline at end of file +} // namespace cuvs::cluster::kmeans::detail diff --git a/cpp/src/cluster/detail/kmeans_balanced.cuh b/cpp/src/cluster/detail/kmeans_balanced.cuh index 3f1ad2334..ba4cabbde 100644 --- a/cpp/src/cluster/detail/kmeans_balanced.cuh +++ b/cpp/src/cluster/detail/kmeans_balanced.cuh @@ -25,7 +25,8 @@ #include #include -#include +#include +#include #include #include #include @@ -59,7 +60,6 @@ namespace cuvs::cluster::kmeans::detail { -static const std::string RAFT_NAME = "raft"; constexpr static inline float kAdjustCentersWeight = 7.0f; /** diff --git a/cpp/src/cluster/detail/kmeans_common.cuh b/cpp/src/cluster/detail/kmeans_common.cuh index eec71b5d2..03db08bd1 100644 --- a/cpp/src/cluster/detail/kmeans_common.cuh +++ b/cpp/src/cluster/detail/kmeans_common.cuh @@ -24,7 +24,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/cpp/src/distance/detail/sparse/coo_spmv_kernel.cuh b/cpp/src/distance/detail/sparse/coo_spmv_kernel.cuh index 1f4b19af4..e44edc68a 100644 --- a/cpp/src/distance/detail/sparse/coo_spmv_kernel.cuh +++ b/cpp/src/distance/detail/sparse/coo_spmv_kernel.cuh @@ -16,6 +16,8 @@ #pragma once +#include + #include #include #include diff --git a/cpp/src/neighbors/detail/ann_utils.cuh b/cpp/src/neighbors/detail/ann_utils.cuh index 529356351..149eea3f1 100644 --- a/cpp/src/neighbors/detail/ann_utils.cuh +++ b/cpp/src/neighbors/detail/ann_utils.cuh @@ -18,7 +18,7 @@ #include #include -#include +#include #include #include #include diff --git a/cpp/src/neighbors/detail/cagra/add_nodes.cuh b/cpp/src/neighbors/detail/cagra/add_nodes.cuh index 952039130..358b7643e 100644 --- a/cpp/src/neighbors/detail/cagra/add_nodes.cuh +++ b/cpp/src/neighbors/detail/cagra/add_nodes.cuh @@ -31,8 +31,6 @@ namespace cuvs::neighbors::cagra { -static const std::string RAFT_NAME = "raft"; - template void add_node_core( raft::resources const& handle, diff --git a/cpp/src/neighbors/detail/cagra/cagra_build.cuh b/cpp/src/neighbors/detail/cagra/cagra_build.cuh index b7fec724b..340986448 100644 --- a/cpp/src/neighbors/detail/cagra/cagra_build.cuh +++ b/cpp/src/neighbors/detail/cagra/cagra_build.cuh @@ -26,7 +26,7 @@ #include #include #include -#include +#include #include #include @@ -46,8 +46,6 @@ namespace cuvs::neighbors::cagra::detail { -static const std::string RAFT_NAME = "raft"; - template void write_to_graph(raft::host_matrix_view knn_graph, raft::host_matrix_view neighbors_host_view, diff --git a/cpp/src/neighbors/detail/cagra/cagra_serialize.cuh b/cpp/src/neighbors/detail/cagra/cagra_serialize.cuh index 0f6cf852f..c83da7bb1 100644 --- a/cpp/src/neighbors/detail/cagra/cagra_serialize.cuh +++ b/cpp/src/neighbors/detail/cagra/cagra_serialize.cuh @@ -18,7 +18,7 @@ #include #include -#include +#include #include #include #include @@ -34,8 +34,6 @@ namespace cuvs::neighbors::cagra::detail { -static const std::string RAFT_NAME = "raft"; - constexpr int serialization_version = 4; /** diff --git a/cpp/src/neighbors/detail/cagra/compute_distance.hpp b/cpp/src/neighbors/detail/cagra/compute_distance.hpp index 7eb798459..2227e4f9e 100644 --- a/cpp/src/neighbors/detail/cagra/compute_distance.hpp +++ b/cpp/src/neighbors/detail/cagra/compute_distance.hpp @@ -22,7 +22,7 @@ #include #include #include -#include +#include #include // TODO: This shouldn't be invoking spatial/knn diff --git a/cpp/src/neighbors/detail/cagra/search_multi_cta.cuh b/cpp/src/neighbors/detail/cagra/search_multi_cta.cuh index ecfd856f1..9cb432bcb 100644 --- a/cpp/src/neighbors/detail/cagra/search_multi_cta.cuh +++ b/cpp/src/neighbors/detail/cagra/search_multi_cta.cuh @@ -26,7 +26,7 @@ #include #include -#include +#include #include #include #include diff --git a/cpp/src/neighbors/detail/cagra/search_multi_cta_kernel-inl.cuh b/cpp/src/neighbors/detail/cagra/search_multi_cta_kernel-inl.cuh index 9fa9d5894..7535ff217 100644 --- a/cpp/src/neighbors/detail/cagra/search_multi_cta_kernel-inl.cuh +++ b/cpp/src/neighbors/detail/cagra/search_multi_cta_kernel-inl.cuh @@ -26,7 +26,7 @@ #include "utils.hpp" #include -#include +#include #include #include #include diff --git a/cpp/src/neighbors/detail/cagra/search_multi_kernel.cuh b/cpp/src/neighbors/detail/cagra/search_multi_kernel.cuh index c6fe21642..469c80a08 100644 --- a/cpp/src/neighbors/detail/cagra/search_multi_kernel.cuh +++ b/cpp/src/neighbors/detail/cagra/search_multi_kernel.cuh @@ -23,7 +23,7 @@ #include "utils.hpp" #include -#include +#include #include #include diff --git a/cpp/src/neighbors/detail/cagra/search_single_cta.cuh b/cpp/src/neighbors/detail/cagra/search_single_cta.cuh index fa71dbaf9..161aa8c4a 100644 --- a/cpp/src/neighbors/detail/cagra/search_single_cta.cuh +++ b/cpp/src/neighbors/detail/cagra/search_single_cta.cuh @@ -26,7 +26,7 @@ #include "utils.hpp" #include -#include +#include #include #include #include diff --git a/cpp/src/neighbors/detail/cagra/search_single_cta_kernel-inl.cuh b/cpp/src/neighbors/detail/cagra/search_single_cta_kernel-inl.cuh index 678ed0cb4..188862fbb 100644 --- a/cpp/src/neighbors/detail/cagra/search_single_cta_kernel-inl.cuh +++ b/cpp/src/neighbors/detail/cagra/search_single_cta_kernel-inl.cuh @@ -28,7 +28,7 @@ #include #include -#include +#include #include #include #include @@ -64,7 +64,6 @@ namespace cuvs::neighbors::cagra::detail { namespace single_cta_search { -using raft::RAFT_NAME; // TODO: this is required for RAFT_LOG_XXX messages. // #define _CLK_BREAKDOWN diff --git a/cpp/src/neighbors/detail/dataset_serialize.hpp b/cpp/src/neighbors/detail/dataset_serialize.hpp index 0ecc2cf5d..ba3090b59 100644 --- a/cpp/src/neighbors/detail/dataset_serialize.hpp +++ b/cpp/src/neighbors/detail/dataset_serialize.hpp @@ -21,7 +21,7 @@ #include #include -#include +#include #include diff --git a/cpp/src/neighbors/detail/dynamic_batching.cuh b/cpp/src/neighbors/detail/dynamic_batching.cuh index 5c6b1654e..cb8e08ef5 100644 --- a/cpp/src/neighbors/detail/dynamic_batching.cuh +++ b/cpp/src/neighbors/detail/dynamic_batching.cuh @@ -50,8 +50,6 @@ namespace cuvs::neighbors::dynamic_batching::detail { -using raft::RAFT_NAME; // TODO: a workaround for RAFT_LOG_XXX macros - /** * A helper to make the requester threads more cooperative when busy-spinning. * It is used in the wait loops across this file to reduce the CPU usage. diff --git a/cpp/src/neighbors/detail/vamana/vamana_build.cuh b/cpp/src/neighbors/detail/vamana/vamana_build.cuh index da24decb3..ec75c99c1 100644 --- a/cpp/src/neighbors/detail/vamana/vamana_build.cuh +++ b/cpp/src/neighbors/detail/vamana/vamana_build.cuh @@ -29,7 +29,7 @@ #include #include #include -#include +#include #include #include #include @@ -52,8 +52,6 @@ namespace cuvs::neighbors::experimental::vamana::detail { * @{ */ -static const std::string RAFT_NAME = "raft"; - static const int blockD = 32; static const int maxBlocks = 10000; diff --git a/cpp/src/neighbors/detail/vamana/vamana_serialize.cuh b/cpp/src/neighbors/detail/vamana/vamana_serialize.cuh index a554464f6..c360ae19a 100644 --- a/cpp/src/neighbors/detail/vamana/vamana_serialize.cuh +++ b/cpp/src/neighbors/detail/vamana/vamana_serialize.cuh @@ -20,7 +20,7 @@ #include #include -#include +#include #include #include #include diff --git a/cpp/src/neighbors/detail/vamana/vamana_structs.cuh b/cpp/src/neighbors/detail/vamana/vamana_structs.cuh index 86cb4e1f8..f6f0279f7 100644 --- a/cpp/src/neighbors/detail/vamana/vamana_structs.cuh +++ b/cpp/src/neighbors/detail/vamana/vamana_structs.cuh @@ -29,7 +29,7 @@ #include #include #include -#include +#include #include #include diff --git a/cpp/src/neighbors/detail/vpq_dataset.cuh b/cpp/src/neighbors/detail/vpq_dataset.cuh index d85bad920..0d7882b4b 100644 --- a/cpp/src/neighbors/detail/vpq_dataset.cuh +++ b/cpp/src/neighbors/detail/vpq_dataset.cuh @@ -25,7 +25,7 @@ #include #include -#include +#include #include #include #include diff --git a/cpp/src/neighbors/ivf_flat/ivf_flat_build.cuh b/cpp/src/neighbors/ivf_flat/ivf_flat_build.cuh index d6ffc1218..f594343c7 100644 --- a/cpp/src/neighbors/ivf_flat/ivf_flat_build.cuh +++ b/cpp/src/neighbors/ivf_flat/ivf_flat_build.cuh @@ -27,7 +27,8 @@ #include "../../cluster/kmeans_balanced.cuh" #include "../detail/ann_utils.cuh" #include -#include +#include +#include #include #include #include diff --git a/cpp/src/neighbors/ivf_flat/ivf_flat_interleaved_scan.cuh b/cpp/src/neighbors/ivf_flat/ivf_flat_interleaved_scan.cuh index f5a4267cd..79b4f1a18 100644 --- a/cpp/src/neighbors/ivf_flat/ivf_flat_interleaved_scan.cuh +++ b/cpp/src/neighbors/ivf_flat/ivf_flat_interleaved_scan.cuh @@ -23,7 +23,7 @@ #include "../detail/ann_utils.cuh" #include -#include // RAFT_LOG_TRACE +#include #include #include #include // RAFT_CUDA_TRY diff --git a/cpp/src/neighbors/ivf_flat/ivf_flat_search.cuh b/cpp/src/neighbors/ivf_flat/ivf_flat_search.cuh index 032b6a8ff..2df6f4f0e 100644 --- a/cpp/src/neighbors/ivf_flat/ivf_flat_search.cuh +++ b/cpp/src/neighbors/ivf_flat/ivf_flat_search.cuh @@ -27,7 +27,8 @@ #include // is_min_close, DistanceType #include // cuvs::selection::select_k #include -#include // RAFT_LOG_TRACE +#include +#include #include #include // raft::resources #include // raft::linalg::gemm diff --git a/cpp/src/neighbors/ivf_pq/ivf_pq_build.cuh b/cpp/src/neighbors/ivf_pq/ivf_pq_build.cuh index 1d4acea1e..44a1b11fa 100644 --- a/cpp/src/neighbors/ivf_pq/ivf_pq_build.cuh +++ b/cpp/src/neighbors/ivf_pq/ivf_pq_build.cuh @@ -30,7 +30,7 @@ #include "../../cluster/kmeans_balanced.cuh" #include -#include +#include #include #include #include @@ -68,7 +68,6 @@ #include namespace cuvs::neighbors::ivf_pq::detail { -using raft::RAFT_NAME; // TODO: this is required for RAFT_LOG_XXX messages. using namespace cuvs::spatial::knn::detail; // NOLINT using internal_extents_t = int64_t; // The default mdspan extent type used internally. diff --git a/cpp/src/neighbors/ivf_pq/ivf_pq_fp_8bit.cuh b/cpp/src/neighbors/ivf_pq/ivf_pq_fp_8bit.cuh index 5b41e5f3d..1b098ac5c 100644 --- a/cpp/src/neighbors/ivf_pq/ivf_pq_fp_8bit.cuh +++ b/cpp/src/neighbors/ivf_pq/ivf_pq_fp_8bit.cuh @@ -20,7 +20,7 @@ #include #include -#include +#include #include #include #include diff --git a/cpp/src/neighbors/ivf_pq/ivf_pq_search.cuh b/cpp/src/neighbors/ivf_pq/ivf_pq_search.cuh index db8f9fbd3..05bb99353 100644 --- a/cpp/src/neighbors/ivf_pq/ivf_pq_search.cuh +++ b/cpp/src/neighbors/ivf_pq/ivf_pq_search.cuh @@ -28,7 +28,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/cpp/src/neighbors/ivf_pq/ivf_pq_serialize.cuh b/cpp/src/neighbors/ivf_pq/ivf_pq_serialize.cuh index 5eaebe69d..4af9dbb8e 100644 --- a/cpp/src/neighbors/ivf_pq/ivf_pq_serialize.cuh +++ b/cpp/src/neighbors/ivf_pq/ivf_pq_serialize.cuh @@ -21,7 +21,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/cpp/src/neighbors/mg/omp_checks.cpp b/cpp/src/neighbors/mg/omp_checks.cpp index e09182dfe..c8cc27414 100644 --- a/cpp/src/neighbors/mg/omp_checks.cpp +++ b/cpp/src/neighbors/mg/omp_checks.cpp @@ -18,7 +18,6 @@ #include namespace cuvs::neighbors::mg { -using raft::RAFT_NAME; void check_omp_threads(const int requirements) { diff --git a/cpp/test/CMakeLists.txt b/cpp/test/CMakeLists.txt index 4d13daaed..cca061455 100644 --- a/cpp/test/CMakeLists.txt +++ b/cpp/test/CMakeLists.txt @@ -89,7 +89,7 @@ function(ConfigureTest) endfunction() add_library(test_rmm_logger OBJECT) -target_link_libraries(test_rmm_logger PRIVATE rmm::rmm_logger_impl) +target_link_libraries(test_rmm_logger PRIVATE rmm::rmm_logger_impl raft::raft_logger_impl) # ################################################################################################## # test sources ################################################################################## @@ -236,7 +236,7 @@ if(BUILD_TESTS) NAME SPARSE_TEST PATH sparse/cluster/cluster_solvers.cu sparse/cluster/eigen_solvers.cu sparse/cluster/spectral.cu GPUS 1 PERCENT 100 ) - + ConfigureTest( NAME PREPROCESSING_TEST PATH preprocessing/scalar_quantization.cu GPUS 1 PERCENT 100 ) diff --git a/cpp/test/neighbors/ann_ivf_pq.cuh b/cpp/test/neighbors/ann_ivf_pq.cuh index 3a92b5e3d..01efd804e 100644 --- a/cpp/test/neighbors/ann_ivf_pq.cuh +++ b/cpp/test/neighbors/ann_ivf_pq.cuh @@ -31,8 +31,6 @@ namespace cuvs::neighbors::ivf_pq { -using raft::RAFT_NAME; // For logging - struct test_ivf_sample_filter { static constexpr unsigned offset = 300; }; diff --git a/cpp/test/neighbors/ann_utils.cuh b/cpp/test/neighbors/ann_utils.cuh index 94bccade2..ded8cb5af 100644 --- a/cpp/test/neighbors/ann_utils.cuh +++ b/cpp/test/neighbors/ann_utils.cuh @@ -38,8 +38,6 @@ namespace cuvs::neighbors { -using raft::RAFT_NAME; // For logging - struct print_dtype { cudaDataType_t value; }; diff --git a/cpp/test/neighbors/brute_force.cu b/cpp/test/neighbors/brute_force.cu index 8c354baa9..2cefb1098 100644 --- a/cpp/test/neighbors/brute_force.cu +++ b/cpp/test/neighbors/brute_force.cu @@ -76,11 +76,9 @@ class KNNTest : public ::testing::TestWithParam> { protected: void testBruteForce() { - // #if (RAFT_ACTIVE_LEVEL >= RAFT_LEVEL_DEBUG) raft::print_device_vector("Input array: ", input_.data(), rows_ * cols_, std::cout); std::cout << "K: " << k_ << std::endl; raft::print_device_vector("Labels array: ", search_labels_.data(), rows_, std::cout); - // #endif auto index = raft::make_device_matrix_view( (const T*)(input_.data()), rows_, cols_);