-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] add wheel tests in CI #1344
Comments
I'd rather wait to test kvikio until we have kvikio wheels. Aside from that, agree with everything here. |
Wheels were added in the since merged PR: rapidsai/kvikio#369 Also with the completion of the RAPIDS 24.8 release, PyPI now has So think this is now actionable |
Should add I saw this comment in the code that was added in PR: #1343 Lines 185 to 188 in 49ebabc
Is this also part of this task or is there a separate issue tracking this item? |
I think yes, because that section only updates the |
Description
This project currently produces wheels but doesn't have any tests on those wheels in CI.
Some should be added.
Benefits of this work
Acceptance Criteria
dask-cuda
wheels are tested in CI, for at least one combination of({python}, {cuda}, {linux})
from the set of things supported by the rest of RAPIDS (and ideally more)Approach
Use the existing wheel-testing workflows from
shared-workflows
, e.g. https://github.com/rapidsai/shared-workflows/blob/branch-24.08/.github/workflows/wheels-test.yaml.For a specific example testing another pure-Python package, see
cuxfilter
:Notes
As of this writing, some tests rely on
kvikio
butkvikio
does not yet have wheels (rapidsai/kvikio#369). If there are still notkvikio
wheels as of when this is picked up, it could be installed in the test environment usingconda
.There are other RAPIDS projects that depend on
dask-cuda
, install its wheels, and use the package installed via those wheels in CI. For example,cuml
: https://github.com/rapidsai/cuml/blob/1560886d30cfe7d4472f334d487e5b9c136a270d/python/pyproject.toml#L91. That does provide some indirect testing.This issue is just about adding such testing here in this repo, where the wheels are produced.
The text was updated successfully, but these errors were encountered: