Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): Search for .conda packages to upload too #108

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jakirkham
Copy link
Member

Part of issue: rapidsai/build-planning#98

Uses find's -o option to search for .conda or .tar.bz2 files to upload

Once collected the anaconda upload command later should take care of the rest

@jakirkham jakirkham changed the title Search for .conda packages to upload too FEAT: Search for .conda packages to upload too Aug 29, 2024
@jakirkham jakirkham changed the title FEAT: Search for .conda packages to upload too feat: Search for .conda packages to upload too Aug 29, 2024
@jakirkham jakirkham requested a review from ajschmidt8 August 29, 2024 19:54
@jameslamb jameslamb changed the title feat: Search for .conda packages to upload too chore(refactor): Search for .conda packages to upload too Aug 30, 2024
@jameslamb
Copy link
Member

jameslamb commented Aug 30, 2024

Hey @jakirkham I change the title of this to start with chore(refactor). This repo uses https://github.com/semantic-release/semantic-release to automatically do a version bump + release on new commits, based on their title.

From that project's docs:

image

Commits starting with chore don't lead to a new release (see the history at https://github.com/rapidsai/dependency-file-generator/commits/main/). Since this change is only modifying a CI script, I don't think we want it to trigger a new release of rapids-dependency-file-generator.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 30, 2024
@jameslamb jameslamb merged commit e722fec into rapidsai:main Aug 30, 2024
5 of 7 checks passed
@jakirkham
Copy link
Member Author

Ok sounds good. Thanks James! 🙏

Appreciate the help reviewing these and the detailed explanation

@GPUtester
Copy link

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jakirkham jakirkham deleted the upload_dot_conda branch September 23, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants