Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dfg does not clean up nonexistent lists in dependencies.yaml #44

Open
vyasr opened this issue Mar 27, 2023 · 1 comment
Open

dfg does not clean up nonexistent lists in dependencies.yaml #44

vyasr opened this issue Mar 27, 2023 · 1 comment

Comments

@vyasr
Copy link
Contributor

vyasr commented Mar 27, 2023

The pyproject.toml support is based on overwriting the file in place. If a particular table/key that was previously being overwritten is removed altogether from dependencies.yaml, however, the resulting list will not be removed from the file. For instance, if all test dependencies were to be removed from a dependencies.yaml file, the project.optional-dependencies.test key would continue to exist in the pyproject.toml file.

Currently this problem is fairly academic since there are almost no cases where a project has 0 dependencies in any section, and it is even less likely that a project with nonzero dependencies removes all of them. I am documenting this issue for now, but there is no immediate rush to fix it. The solution would likely be to erase all dependency-related keys at the beginning of every run, similar to how the cli cleans up files.

@jameslamb
Copy link
Member

there are almost no cases where a project has 0 dependencies in any section

Just observed one of these! Linking here for context: rapidsai/cudf#16681 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants