Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long-form docs on configuration options #31

Open
jameslamb opened this issue May 9, 2024 · 1 comment
Open

Add long-form docs on configuration options #31

jameslamb opened this issue May 9, 2024 · 1 comment
Labels
doc Improvements or additions to documentation

Comments

@jameslamb
Copy link
Member

Description

The table in the README listing configuration options is useful to see what's available at a glance. It's also a great way to get an idea of what types of concerns rapids-build-backend is meant to address.

But the table format is really limiting... putting more than a few words describing a given configuration option would reduce the visual usefulness of the table fast (since it would grow the how table vertically).

At some point, I think it'd be useful to write dedicated documentation with long-form descriptions covering the following for each configuration option:

  • what are the valid values?
  • when might you want to override the default?
  • how do the options relate to each other?

Benefits of this work

Improves the likelihood that someone building with this backend could be productive on their own.

Acceptance Criteria

  • long form docs exist for all the config options

Approach

I am thinking something like a docs/config.rst, with content similar to this:

commit-file
'''''''''''''''''''

``rapids-build-backend`` automatically records the current git commit for the source tree it's building from, and writes that to a text file bundled into the wheel.

By default, that will be in a file `{[project].name}/GIT_COMMIT`. For example, given a `pyproject.toml` like this:

[project]
name = "sparkly-unicorn"

rapids-build-backend will write out that commit sha to a location ``./sparkly_unicorn/GIT_COMMIT``, relative to wherever that ``pyproject.toml`` file is.

Provide some other relative path here to override that behavior and tell it to write to a custom location.

I think it'd be fine for that to just live in a file in this repo. This issue could be considered "done", in my opinion, without setting up any docs rendering or hosting.

Some good references for this:

Notes

N/A

@jameslamb jameslamb added the doc Improvements or additions to documentation label May 9, 2024
@vyasr
Copy link
Contributor

vyasr commented May 9, 2024

I agree, some documentation would be good. I think it's probably worthwhile to wait until we stabilize a bit more, though, since we are currently in a decent amount of flux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants