-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] rapids_cpm_spdlog generate correct build config support #387
Comments
Adding some links. I think that instead of doing this for projects in Assuming rapidsai/build-planning#56 is completed (see #592), across RAPIDS we'll be using |
I think this would could be closed if the following are merged: |
## Description Replaces #15603 Contributes to: * rapidsai/build-planning#54 * rapidsai/build-planning#56 * rapidsai/rapids-cmake#387 Now that most of `conda-forge` has been updated to `fmt >=11.0.1,<12` and `spdlog>=1.14.1,<1.15` (rapidsai/build-planning#56 (comment)), we're attempting to upgrade RAPIDS to similar versions of those libraries. This improves the likelihood that RAPIDS will be installable alongside newer versions of its dependencies and complementary packages on conda-forge. ## Notes for Reviewers This PR is testing changes made in rapidsai/rapids-cmake#689. It shouldn't be merged until those `rapids-cmake` changes are merged and any testing-specific details have been removed.
I think this can be closed! The now-extraneous There are not any remaining across RAPIDS: https://github.com/search?q=org%3Arapidsai+%22NAMESPACE+spdlog%3A%3A%22+AND+NOT+is%3Aarchived&type=code |
Currently projects need to manually generate a build directory config module ( e.g. )
Describe the solution you'd like
We should do this for projects in rapids_cpm_spdlog
The text was updated successfully, but these errors were encountered: