[Bug]: Missing table header class

[danie-ramdhani]

What happened?

The table header when the column is not sortable, the class is not applied to the label correctly:

How to reproduce the bug

No response

Package Version

3.4.21

PHP Version

None

Laravel Version

No response

Alpine Version

No response

Theme

Tailwind 3.x

Notes

No response

Error Message

No response

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[lrljoe]

This should be fixed in 3.5.0, please let me know if not the case!

[danie-ramdhani]

i've upgrade to latest version (3.5.0) + clear the cache and it still missing. and its not the table header class, but the element inside it 😅.

[lrljoe]

Can you share what you're doing to create that Column please?

Do you have any custom setThAttributes/setTdAttributes/setTrAttributes in your configure?

[danie-ramdhani]

i just have regular custom class.

to reproduce it is simple. create column that use sortable() and another column is not using it.

and in latest version (3.5.0) the span doesn't have basic classes because it's not wrapped inside the button:

[lrljoe]

i just have regular custom class.

Just to validate - have you previously published the views?

Will try to replicate what you've got, to see if I can reproduce.

[danie-ramdhani]

No i don't.

[lrljoe]

No i don't.

Just so I can narrow it down a bit

  $this->setThSortButtonAttributes(function(Column $column) {
    if ($column->isField('deleted_at')) {
      return [
        'class' => 'bg-green-500',
      ];
    }
 
    return [];
  });

I do need to get it all back in alignment, but this should help me focus where the issue is:

[danie-ramdhani]

ok, so tried it. and when the column is not sortable, it doens't apply the styles:

$this->setThSortButtonAttributes(function (Column $column) {
    if ($column->isField('avatar')) {
        return [
            'class' => 'bg-green-500',
        ];
    }

    if ($column->isField('role')) {
        return [
            'class' => 'bg-green-500',
        ];
    }

    return [];
});

result:

like i said before the sortable column is wrapped inside the button (and all the styles is only on the button, not span element)

[lrljoe]

Thanks for the detail, I'll try to get a fix out this weekend.

I imagine it'll just need a little bit more specificity in terms of what to return (standard TH vs Sortable TH)

[lrljoe]

Hmmm

$this->setThSortButtonAttributes(function (Column $column) {
    if ($column->isField('avatar')) {
        return [
            'class' => 'bg-green-500',
        ];
    }

    if ($column->isField('role')) {
        return [
            'class' => 'bg-green-500',
        ];
    }

    return [];
});

IS working as expected.

It's applying the "class" attribute you selected (bg-green-500) to the button element for "role".
The Column "avatar" isn't a sortable Column.

[lrljoe]

You'd want the "setLabelAttributes" for a Column to set the attributes for the "span", from what I recall.

It's something that does need cleaning up admittedly!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.