feat: support default function for containerEnv on additionalWorkerGroups in ray-cluster helm chart #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oups in ray-cluster helm chart; Signed-off-by: ahmed.g <[email protected]> Signed-off-by: TessaIO <[email protected]>
kevin85421
reviewed
Nov 27, 2024
|
Couple of tests: 2- We test the old behavior where we set a containerEnv, and we should it being added in the manifest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Make the deployment of ray-cluster helm chart with containerEnv not being specified easier using Terraform.
Related issue number
Closes #2569
Checks