From 396493b224b957e79fcd93b49bb0db8e3abc5427 Mon Sep 17 00:00:00 2001 From: Dery Rahman Ahaddienata Date: Wed, 18 Jan 2023 14:28:07 +0700 Subject: [PATCH] fix: temporary fix for double cyclic (#725) --- core/job/service/job_service.go | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/core/job/service/job_service.go b/core/job/service/job_service.go index 1b1d13680c..e4afee0e35 100644 --- a/core/job/service/job_service.go +++ b/core/job/service/job_service.go @@ -357,15 +357,10 @@ func (j JobService) Validate(ctx context.Context, jobTenant tenant.Tenant, jobSp } // check cyclic deps for every job - isAlreadyCyclic := map[string]bool{} for _, jobEntity := range jobsWithUnresolvedUpstreams { - if jobNamesWithCyclic, err := j.validateCyclic(jobEntity.Job().Spec().Name(), jobMap, identifierToJobsMap); err != nil { - if _, ok := isAlreadyCyclic[jobEntity.Job().Spec().Name().String()]; !ok { - me.Append(err) - } - for _, jobName := range jobNamesWithCyclic { - isAlreadyCyclic[jobName] = true - } + if _, err := j.validateCyclic(jobEntity.Job().Spec().Name(), jobMap, identifierToJobsMap); err != nil { + me.Append(err) + break } }