Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zap contextual logging naming #52

Closed
mabdh opened this issue Sep 14, 2022 · 0 comments · Fixed by #51
Closed

Fix zap contextual logging naming #52

mabdh opened this issue Sep 14, 2022 · 0 comments · Fixed by #51
Assignees
Labels
enhancement New feature or request

Comments

@mabdh
Copy link
Member

mabdh commented Sep 14, 2022

Is your feature request related to a problem? Please describe.
The contextual logging with zap in salt is inside log package. Getting zap log from context would be log.FromContext(ctx) and return Zap. Since log has multiple possible logger (logrus & zap), this would be confusing.

Describe the solution you'd like
Add more specific identifier for Zap logger specific function to make it clearer.
log.FromContext > log.ZapFromContext
log.WithFields > log.ZapContextWithFields

@mabdh mabdh added the enhancement New feature or request label Sep 14, 2022
@mabdh mabdh self-assigned this Sep 14, 2022
@mabdh mabdh linked a pull request Sep 14, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant