Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Defaults: Volume, Do Not Talk times required #17

Open
rayzurbock opened this issue Feb 2, 2016 · 3 comments
Open

Configure Defaults: Volume, Do Not Talk times required #17

rayzurbock opened this issue Feb 2, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@rayzurbock
Copy link
Owner

The "optional" Volume, "Do not talk before", and "Do not talk after" settings on the Configure Defaults page seem to be required.

Reported 2/1/2016 by STCommunity:gcortes

@rayzurbock rayzurbock added this to the Investigating milestone Feb 2, 2016
@rayzurbock rayzurbock self-assigned this Feb 2, 2016
@rayzurbock rayzurbock added the bug label Mar 19, 2016
@rayzurbock
Copy link
Owner Author

I believe this is going to be found in BigTalker 1.1.5 on line 1660. I don't think the expression required: (!(settings.defaultStartTime == null)) is being evaluated as I expected in this line:
input "defaultEndTime", "time", title: "Don't talk after: ", required: (!(settings.defaultStartTime == null)), submitOnChange: true

Will likely need to change to:
required: ((settings.defaultStartTime != null && settings.defaultStartTime != "") ? true : false)

@rayzurbock
Copy link
Owner Author

Also, I believe line 3218 needs to be addressed.
if (settings.defaultStartTime == null) {

should probably be changed to:
if ((settings.defaultStartTime != null && settings.defaultStartTime != "") ? false : true) {

@rayzurbock
Copy link
Owner Author

Beta version posted here: https://github.com/rayzurbock/SmartThings-BigTalker/tree/1.1.6-Beta
Please test and let me know if you find this issue now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant