Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Razorpay Version 2.9.1 for NodeJS uses Vulnerable Dependencies #372

Open
jeetchheda opened this issue Aug 8, 2023 · 4 comments
Open

Razorpay Version 2.9.1 for NodeJS uses Vulnerable Dependencies #372

jeetchheda opened this issue Aug 8, 2023 · 4 comments
Assignees
@ankitdas13
Labels
security

Comments

@jeetchheda
Copy link

Screenshot 2023-08-08 193441
@ankitdas13 ankitdas13 self-assigned this Aug 24, 2023
@Abhishekucs
Copy link

I removed the request and its dependent package and used node-fetch for the same. Created a pull request fix:ssrf #376. Please check.

@jeetchheda
Copy link
Author

Guys, what is the update with this bugfix ? Please get it tested and live soon. Waiting on you guys to make my project reach 0 vulnerabilities.

@charanjit-singh
Copy link

@razorpay-sanjib @aishrazorpay @amitrazorpay @bala-razorpay @KanhaRazorpay @tanmayrazorpay

@gaganbiswas
Copy link

Created a PR #397 which resolves the issue. Used axios instead of request and request-promise.

Here is the comparison chart for alternatives of request package: https://github.com/sindresorhus/got#comparison

P.S.: Wanted to use got but they don't support commonjs anymore since v11 (which is no longer maintained), so used axios instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitdas13 ankitdas13

Labels
security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@charanjit-singh @Abhishekucs @gaganbiswas @ankitdas13 @jeetchheda