Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror doesn't ensure order nor delivery #3

Open
dckc opened this issue Aug 1, 2020 · 1 comment
Open

mirror doesn't ensure order nor delivery #3

dckc opened this issue Aug 1, 2020 · 1 comment

Comments

@dckc
Copy link

dckc commented Aug 1, 2020

The code to mirror postgres events to RChain doesn't ensure that the contract returns success.

https://github.com/rchain-community/rv2020/blob/41318189b5eba92b7b5a9586e871b05d6e90af02/rchat/chain_replica.js#L113

Nor does it ensure that the updates are executed in order.

@dckc
Copy link
Author

dckc commented Aug 3, 2020

The RChain deploy and such is currently async w.r.t. the DB operation. I think triggers can cause DB operations to fail, though the performance implication of putting an RChain contract execution (which currently takes around 3 minutes) in the critical path of each DB operation seems pretty drastic.

@jimscarver jimscarver transferred this issue from rchain-community/rvote Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant