Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Participate.js should read the config files for master URI #187

Open
Bill-Kunj opened this issue Jun 3, 2021 · 6 comments
Open

Participate.js should read the config files for master URI #187

Bill-Kunj opened this issue Jun 3, 2021 · 6 comments
Assignees
Labels

Comments

@Bill-Kunj
Copy link
Collaborator

Yes, a configuration file would be appropriate.

Note that a configuration file doesn't get imported. import is for source code; i.e. design-time materials.

A configuration file would get read in at runtime.

(Another alternative would be an environment variable, as advocated by https://12factor.net/config )

Originally posted by @dckc in #185 (comment)

@Bill-Kunj Bill-Kunj added the ui UI / UX label Jun 3, 2021
@Bill-Kunj Bill-Kunj added this to the October coop voting app milestone Jun 3, 2021
@Bill-Kunj
Copy link
Collaborator Author

@jimscarver Has this been addressed for the purposes of rv2021?

@David405
Copy link
Collaborator

@Bill-Kunj does hardcoding the values work?

@Bill-Kunj
Copy link
Collaborator Author

@Bill-Kunj does hardcoding the values work?

@David405 I don't think so.
@jimscarver What do we need for rv2021?

@Bill-Kunj
Copy link
Collaborator Author

@Bill-Kunj does hardcoding the values work?

@David405 I don't think so.
@jimscarver What do we need for rv2021?

@dckc Please confirm that I am correct that hard-coding is not the solution here?

@dckc
Copy link
Contributor

dckc commented Aug 28, 2021

I agree: the master URI is not a design-time constant -- it changes at runtime depending on the chain -- so it doesn't belong in the source code.

@jimscarver
Copy link
Contributor

the legacy code hard codes the uri's but that not how we want to do it. For 2021 if it works this week with the uris hard coded that is good enough. Taking the uris out of the code is the priority once it works at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants