Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hack #97

Open
rdbende opened this issue Jul 1, 2023 · 3 comments · May be fixed by #121
Open

Add hack #97

rdbende opened this issue Jul 1, 2023 · 3 comments · May be fixed by #121

Comments

@rdbende
Copy link
Owner

rdbende commented Jul 1, 2023

From Akuli/porcupine:

# TODO: the next 3 lines are a hack?
# If they are really needed, why it isn't in sv-ttk by default?
main_window.option_add("*Text.highlightThickness", "0")
main_window.option_add("*Text.borderWidth", "2")
main_window.option_add("*Text.relief", "solid")
@littlewhitecloud
Copy link
Contributor

Add hack means add them to the sv_ttk as default?

@rdbende
Copy link
Owner Author

rdbende commented Oct 14, 2023

Yeah, though I'm not sure, if it makes sense to make them the default.

@littlewhitecloud
Copy link
Contributor

littlewhitecloud commented Oct 15, 2023 •
edited
Loading

Hightlightthickness is 0 means the Text widget will not show the highlight border and I agree this, because the border looks ugly.
image
And here is a screenshot that shows the difference between borderwidth=2 and the normal borderwidth, there are 1px black frame in the left and 2px grey frame in the bottom, so I disagree the second.
image
And the relief, here is the screenshot (test with borderwidth=2):
image
I think normal relief is better than the solid, so I think they can set the solid by themself.

So we just need set the highlightthickness=0 as default.
(Of course this is just my option, maybe we can ask Akuli for options.)

@littlewhitecloud littlewhitecloud linked a pull request Oct 15, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add hack littlewhitecloud/Sun-Valley-ttk-theme
2 participants
@littlewhitecloud @rdbende