Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Dependency pointing to personal environment #31

Open
julianrojas87 opened this issue Nov 21, 2024 · 1 comment
Open

Bug: Dependency pointing to personal environment #31

julianrojas87 opened this issue Nov 21, 2024 · 1 comment
Assignees
Labels
invalid This doesn't seem right

Comments

@julianrojas87
Copy link

The rdfc dependency of the python SHACL validator is pointing to a local file with an absolute path:

rdfc @ file:///Users/jens/Developer/technology.idlab.jvm-runner/runners/python/dist/rdfc-0.1.0-py3-none-any.whl

Shouldn't this be a relative path instead? Or shall we publish that dependency as a proper library?

@jenspots
Copy link
Member

You're right, the requirements.txt is actually outdated and should be removed. The actual dependencies are listed in the pyproject.toml file.

"rdfc @ {root:parent:uri}/runner-py/dist/rdfc-0.1.0-py3-none-any.whl"

However, the library itself should at one point be published separately. GitHub doesn't support publishing Python packages yet so I'll look into something like pypi.

@jenspots jenspots self-assigned this Nov 22, 2024
@jenspots jenspots added the invalid This doesn't seem right label Nov 22, 2024
@jenspots jenspots changed the title Dependency pointing to personal environment? Bug: Dependency pointing to personal environment Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants