Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DropdownToggle has the incorrect aria attribute of aria-haspopup #854

Open
romans12 opened this issue Aug 17, 2020 · 1 comment · May be fixed by #855
Open

DropdownToggle has the incorrect aria attribute of aria-haspopup #854

romans12 opened this issue Aug 17, 2020 · 1 comment · May be fixed by #855

Comments

@romans12
Copy link

Describe the bug

DropdownToggle is adding the aria-haspopup="true" when it should not.

Expected behavior

The aria-haspopup=true attribute should only be added if the aria role is menu, listbox, tree, grid, or dialog (https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup).

Read more here: twbs/bootstrap#28295
@taion
Copy link
Member

taion commented Aug 17, 2020

Would you like to send in a PR to fix this? Thanks!

@romans12 romans12 linked a pull request Aug 19, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing aria-haspopup romans12/react-overlays
2 participants
@taion @romans12