[added] button role but no keydown handler

reactjs · Jan 19, 2015 · 109bd94 · 109bd94
1 parent fabf6cc
commit 109bd94
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/__tests__/index-test.js b/lib/__tests__/index-test.js
@@ -66,6 +66,12 @@ describe('props', () => {
           <span onClick={k} role="button"/>;
         });
       });
+
+      it('requires onKeyDown', () => {
+        expectWarning(assertions.props.onClick.BUTTON_ROLE_NO_KEYDOWN.msg, () => {
+          <span onClick={k} role="button"/>;
+        });
+      });
     });
 
     it('warns without role', () => {

diff --git a/lib/assertions.js b/lib/assertions.js
@@ -116,11 +116,19 @@ exports.props = {
     },
 
     BUTTON_ROLE_NO_KEYUP: {
-      msg: 'You have `role="button"` but did not define an `onKeyUp` handler. Add it, and have the "Space" character do the same thing as an `onClick` handler.',
+      msg: 'You have `role="button"` but did not define an `onKeyUp` handler. Add it, and have the "Space" key do the same thing as an `onClick` handler.',
+      test (tagName, props, children) {
+        return !(props.role === 'button' && !props.onKeyUp);
+      }
+    },
+
+    BUTTON_ROLE_NO_KEYDOWN: {
+      msg: 'You have `role="button"` but did not define an `onKeyDown` handler. Add it, and have the "Enter" key do the same thing as an `onClick` handler.',
       test (tagName, props, children) {
         return !(props.role === 'button' && !props.onKeyUp);
       }
     }
+
   }
 };