Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit Recompilation Heuristic + nativeCallTrampoline #1298

Open
skrynski opened this issue Jul 5, 2024 · 0 comments
Open

Revisit Recompilation Heuristic + nativeCallTrampoline #1298

skrynski opened this issue Jul 5, 2024 · 0 comments
Assignees

Comments

@skrynski
Copy link
Collaborator

skrynski commented Jul 5, 2024

We should revisit the recheck == 97 condition. It does not play well with the current recompilation heuristic which decides to recompile every PIR_WARMUP invocations to the function (currently 100), so both conditions must be true simultaneously. Also, recheck is a global variable and other calls most likely increase it in between.
In other words, the chances it will trigger are low.

if (fail || (++recheck == 97 && RecompileHeuristic(fun))) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants