-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUI refactoring facets screen #501
SUI refactoring facets screen #501
Conversation
import ReadiumShared | ||
|
||
extension Feed { | ||
static var preview: Feed { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mickael-menu Perhaps we should move these mocks to the swift-toolkit package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep them here as it's out of scope for the toolkit itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FuzzzzyBoy! I made a couple of changes.
import ReadiumShared | ||
|
||
extension Feed { | ||
static var preview: Feed { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep them here as it's out of scope for the toolkit itself.
No description provided.