Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: openapi:refs touch ups #1103

Merged
merged 6 commits into from
Dec 5, 2024
Merged

fix: openapi:refs touch ups #1103

merged 6 commits into from
Dec 5, 2024

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Dec 5, 2024 •
edited
Loading

🧰 Changes

Touched up a few things in #1063!

  • Documentation copy edits
  • Logging touch ups
  • Makes sure we're only allowing this to be run against OpenAPI
  • Adds a stricter type in 81607ca that ends up breaking the build — I believe this is a code smell. @olehshh can you look into fixing the type errors here?

🧬 QA & Testing

Are my changes sound?

@kanadgupta kanadgupta added bug Something isn't working documentation Improvements or additions to documentation command:openapi Issues pertaining to the `openapi`, `validate`, `reduce`, or `swagger` commands labels Dec 5, 2024
@kanadgupta kanadgupta marked this pull request as ready for review December 5, 2024 00:14
@kanadgupta kanadgupta requested a review from olehshh December 5, 2024 00:14
@olehshh olehshh merged commit b224ec6 into oleh/openapi-adding-command-to-solve-circularity-and-recursiveness Dec 5, 2024
2 of 8 checks passed
@olehshh olehshh deleted the kanad-2024-12-04/openapi-refs-feedback branch December 5, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olehshh olehshh olehshh requested changes

Assignees
No one assigned
Labels
bug Something isn't working command:openapi Issues pertaining to the `openapi`, `validate`, `reduce`, or `swagger` commands documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanadgupta @olehshh