-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding openapi upload
#1116
Draft
kanadgupta
wants to merge
31
commits into
kanad-2024-12-06/remove-openapi
Choose a base branch
from
kanad-2024-12-06/oas-v2-RM-11384
base: kanad-2024-12-06/remove-openapi
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: adding openapi upload
#1116
kanadgupta
wants to merge
31
commits into
kanad-2024-12-06/remove-openapi
from
kanad-2024-12-06/oas-v2-RM-11384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
changed the base branch from
next
to
kanad-2024-12-06/remove-openapi
December 10, 2024 01:16
This was referenced Dec 10, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
outstanding tasks:
optionaledit: might be a good enhancement further down the line, but going to pass on this for now!--action
arg?useSpecVersion
pending
timeout (there's a nock API for duplicating an interceptor, use that!)ideas for future enhancements
--action
arg for use in CI to prevent accidental overwrites--timeout
arg to allow user to configure timeout🧬 QA & Testing
Provide as much information as you can on how to test what you've done.