Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: validate PR titles #885

Merged
merged 2 commits into from
Sep 5, 2023
Merged

ci: validate PR titles #885

merged 2 commits into from
Sep 5, 2023

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Sep 5, 2023

🧰 Changes

Our release process relies on semantic-release and on our PR titles following conventional commit guidelines, so this PR adds a workflow to validate PR titles accordingly.

I also updated our repository settings so we now default to the PR title when merging PRs in (weird how that's not the default):

CleanShot 2023-09-05 at 09 57 35@2x

🧬 QA & Testing

Per their docs on the pull_request_target event, this workflow won't run until it's merged into our default branch so there's no way to test it until then.

@kanadgupta kanadgupta changed the title validate PR titles ci: validate PR titles Sep 5, 2023
@kanadgupta kanadgupta added the enhancement New feature or request label Sep 5, 2023
@kanadgupta kanadgupta requested a review from erunion September 5, 2023 14:58
@kanadgupta kanadgupta marked this pull request as ready for review September 5, 2023 14:58
@kanadgupta kanadgupta merged commit e634a02 into next Sep 5, 2023
9 checks passed
@kanadgupta kanadgupta deleted the pr-title-lint branch September 5, 2023 15:44
@kanadgupta
Copy link
Member Author

🎉 This PR is included in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants