Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be_served_from_origin doesn't work if cache key doesn't include origin hostname #31

Open
amcinnes opened this issue Sep 11, 2018 · 0 comments

Comments

@amcinnes
Copy link

The be_served_from_origin checks the hostname in the cache key, and assumes this is going to be the origin hostname. If you set cache key to incoming host header, be_served_from_origin will fail.

If there's no possible way to check the actual origin hostname, perhaps we could deprecate be_served_from_origin and replace it with something called e.g. have_cache_key_hostname that more clearly describes what it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant