Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDART-874: Conditional for compatibility with AGP <4.2. #1524

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

gokuzhan
Copy link
Contributor

@gokuzhan gokuzhan commented Feb 20, 2024

Gradle Plugin Compatibility Fix

Issue

Launching lib/main.dart on sdk gphone64 arm64 in debug mode...
Running Gradle task 'assembleDebug'...

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':realm'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
   > Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

     If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

flutter doctor -v

Doctor summary (to see all details, run flutter doctor -v):

[✓] Flutter (Channel stable, 3.19.0, on macOS 14.2.1 23C71 darwin-arm64, locale en-IN)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.1)
[✓] VS Code (version 1.86.2)
[✓] Connected device (3 available)
    ! Error: Browsing on the local area network for Candy's iPhone. Ensure the device is unlocked and attached with a cable or associated
      with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)
[✓] Network resources

• No issues found!

Fixes #1388

@gokuzhan gokuzhan marked this pull request as ready for review February 20, 2024 17:22
@nirinchev
Copy link
Member

Hey, thanks for this and sorry for the delayed response. Can you make sure you sign the CLA so we could merge this?

@nirinchev nirinchev changed the title Conditional for compatibility with AGP <4.2. RDART-874: Conditional for compatibility with AGP <4.2. Mar 7, 2024
@nirinchev nirinchev self-assigned this Mar 7, 2024
@nirinchev nirinchev merged commit eca576b into realm:main Mar 7, 2024
1 of 2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add namespace to support Android Gradle Plugin (AGP) 8.x.x
2 participants