Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: weekly_presentation_background #13

Open
thibautjombart opened this issue Oct 25, 2019 · 1 comment
Open

review: weekly_presentation_background #13

thibautjombart opened this issue Oct 25, 2019 · 1 comment
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed review

Comments

@thibautjombart
Copy link
Contributor

We need a review for the weekly_presentation_background report. There is a lot of code duplicated from other reports which needs to be removed; quite possibly, keep only the text automatically generated.

Quick links to:

golden rules for writing reports: https://github.com/reconhub/guides/raw/master/golden_rules.html.zip

guide to review:
https://github.com/reconhub/report_factories_templates#revewing-changes

@thibautjombart thibautjombart added help wanted Extra attention is needed good first issue Good for newcomers review labels Oct 25, 2019
@thibautjombart
Copy link
Contributor Author

@nsbatra flagging you as a representative for HQ ;) This report has a lot that needs removing, essentially all parts that already exist somewhere else. I suspect only the automatically generated text will remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed review
Projects
None yet
Development

No branches or pull requests

2 participants