Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected/undocumented field billing_info_id being returned for Subscription resource #460

Open
food-spotter opened this issue Nov 3, 2020 · 2 comments
Assignees
Labels
question V3 v2019-10-10 Client

Comments

@food-spotter
Copy link

Describe the bug

Unexpected/undocumented field billing_info_id returned for the Subscription Resource in v2019-10-10 of the API.

It is also not described in the Subscription schema/data-model - https://github.com/recurly/recurly-client-python/blob/master/recurly/resources.py#L1392

To Reproduce

pages = self.client.list_subscriptions(
    sort="updated_at", order="asc", limit=200, begin_time=begin_from.isoformat()
).pages()

for page in pages:
    for subscription in page:
        print(subscription.billing_info_id)

Expected behavior

This field should not be returned (thus raise an Error in the above example) since it is not part of the documented list of fields - https://developers.recurly.com/api/v2019-10-10/#operation/get_subscription

Your Environment

  • Which version of this library are you using?
    tested on recurly==3.13.0 and recurly==3.11.0
  • Which version of the language are you using?
    Python 3.8.5
@douglasmiller
Copy link
Contributor

douglasmiller commented Nov 3, 2020

Thank you for taking the time to create this issue, @food-spotter

The billing_info_id is actually a new field that was just added to Recurly API, but hasn't been released in the client libraries (that should be happening today). The developer hub receives updates following the client libraries.

Were you experiencing any issues caused by the presence of the billing_info_id in the response without direct support existing in the client?

@douglasmiller douglasmiller self-assigned this Nov 3, 2020
@food-spotter
Copy link
Author

Hi @douglasmiller ,
That's correct. We were experiencing an issue due to the sudden occurance of this unexpected field being returned by the python-client.

We do some response validation and and this unexpected field raised an issue on our side.

Although we've made changes on our local code to now ignore unexpected fields so this issue is no longer a blocker, I do believe the python-client should only return the expected fields as specified by the API doc.

@joannasese joannasese added the V3 v2019-10-10 Client label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question V3 v2019-10-10 Client
Projects
None yet
Development

No branches or pull requests

3 participants