Fix failure seen with mfa testcase #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ckulal <[email protected]>
ckulal
force-pushed
the
fix_mfa_failure
branch
from
5eaa40c to
672a3b3
Compare
ckulal
added
RGW
anrao19
approved these changes
Feb 28, 2024
mkasturi18
approved these changes
Feb 28, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anrao19, ckulal, mkasturi18 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing issue: cannot unpack non-iterable NoneType object
when put operation of MFA and version enabled is succeeded in the first iteration.
since previously we were returning : return token, mfa_version_put
only in case of the situation where put mfa is a failure: i.e
if mfa_version_put is False:
return token, mfa_version_put
but we are checking condition: if status is False:
https://github.com/red-hat-storage/ceph-qe-scripts/pull/561/files#diff-e65bb0e4957600e7835ff2af409a6e7bff1c9e1cbc5dd3ad2124b41a6b91d0deL149
so if mfa version enable i s successful in first attempt it was not returning any value , but in the script we are looking for the condition check
fail log: http://magna002.ceph.redhat.com/ceph-qe-logs/Chaithra/mfa-failure/test_rgw_mfa.console.log2-fail
Post fix:
Pass log:
http://magna002.ceph.redhat.com/ceph-qe-logs/Chaithra/mfa-failure/test_rgw_mfa.console.log5-pass(where mfs enable success in first attempt)
http://magna002.ceph.redhat.com/ceph-qe-logs/Chaithra/mfa-failure/test_rgw_mfa.console.log3-pass
http://magna002.ceph.redhat.com/ceph-qe-logs/Chaithra/mfa-failure/test_rgw_mfa.console.log4-pass
(where mfs enable success in second attempt)