Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tier-3]:CEPH-83573543: Verify lifecycle removes all the non-current … #602

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

ckulal
Copy link
Contributor

@ckulal ckulal commented Jun 19, 2024

…objects, while the current object is removed via s3cmd

Automation of: Polarian: CEPH-83573543: Verify lifecycle removes all the non-current objects, while the current object is removed via s3cmd

As a part of this PR:

  1. Added script and config to implement Polarian: CEPH-83573543
  2. Enhanced existing script to use global variables
  3. Written reusable methods for rgw service restart and enabling version for existing bucket

Log:
Uploading test_lc_expiration_noncurrent_when_current_object_deleted_via_s3cmd.console-new.log…

@openshift-ci-robot
Copy link

@ckulal: No Jira issue with key CEPH-83573543 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

…objects, while the current object is removed via s3cmd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@ckulal: No Jira issue with key CEPH-83573543 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

…objects, while the current object is removed via s3cmd

Automation of: Polarian: CEPH-83573543: Verify lifecycle removes all the non-current objects, while the current object is removed via s3cmd

As a part of this PR:

  1. Added script and config to implement Polarian: CEPH-83573543
  2. Enhanced existing script to use global variables
  3. Written reusable methods for rgw service restart and enabling version for existing bucket

Log:
test_lc_expiration_noncurrent_when_current_object_deleted_via_s3cmd.console.log

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@ckulal: No Jira issue with key CEPH-83573543 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

…objects, while the current object is removed via s3cmd

Automation of: Polarian: CEPH-83573543: Verify lifecycle removes all the non-current objects, while the current object is removed via s3cmd

As a part of this PR:

  1. Added script and config to implement Polarian: CEPH-83573543
  2. Enhanced existing script to use global variables
  3. Written reusable methods for rgw service restart and enabling version for existing bucket

Log:
Uploading test_lc_expiration_noncurrent_when_current_object_deleted_via_s3cmd.console-new.log…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

…objects, while the current object is removed via s3cmd

Signed-off-by: ckulal <[email protected]>

fix tox

Signed-off-by: ckulal <[email protected]>
@ckulal ckulal added RGW RGW pr-verified close-loop-automation close-loop-automation customer BZ automated as part of close-loop tier-3 tier-3 automation labels Jun 19, 2024
@ckulal ckulal requested a review from a team June 19, 2024 10:28
Copy link
Contributor

@viduship viduship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckulal, Request you to run atleast a few regression tests using the same script.

@ckulal
Copy link
Contributor Author

ckulal commented Jun 21, 2024

@ckulal, Request you to run atleast a few regression tests using the same script.

Regression pass logs for existing config:

test_s3cmd_lifecycle_archive_current_expiration:
Test_LC_on_archive_for_current_versions_0.log

test_s3cmd_lifecycle_archive_noncurrent_expiration:
Test_LC_on_archive_for_non-current_versions_0.log

@ckulal ckulal requested a review from viduship June 21, 2024 09:27
Copy link
Contributor

@viduship viduship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jun 25, 2024
@TejasC88
Copy link
Contributor

LGTM

Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ckulal, mkasturi18, viduship

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot merged commit 7bb5533 into red-hat-storage:master Jun 25, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
close-loop-automation close-loop-automation customer BZ automated as part of close-loop lgtm Looks good to me pr-verified RGW RGW tier-3 tier-3 automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants