Swift at root URL checks #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckulal
reviewed
Jul 26, 2024
| proto = "https" if config.ssl else "http" | ||
| url = f"{proto}://{ip_and_port}/" | ||
|
|
||
| log.info("CHeck swift /info") |
There was a problem hiding this comment.
Minor: typo, please make. a changes in all the places
ckulal
reviewed
Jul 26, 2024
anrao19
reviewed
Jul 26, 2024
| @@ -51,6 +51,7 @@ | |||
| import traceback | |||
|
|
|||
| import names | |||
| import requests | |||
| import v2.lib.manage_data as manage_data | |||
| import v2.lib.resource_op as swiftlib | |||
| import v2.utils.utils as utils | |||
There was a problem hiding this comment.
Please update the config file : configs/test_swift_at_root.yaml
Signed-off-by: Tejas Chandramouli <[email protected]>
hmaheswa
approved these changes
Jul 31, 2024
viduship
approved these changes
Aug 6, 2024
ckulal
approved these changes
Aug 6, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anrao19, ckulal, hmaheswa, TejasC88, viduship The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operations:
Pass log : http://magna002.ceph.redhat.com/cephci-jenkins/tchandra/swift_at_root.txt