Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for sessionStorage in useUserSettingsLocalStorage hook #1629

Open
SanjalKatiyar opened this issue Oct 9, 2024 · 2 comments
Open

Comments

@SanjalKatiyar
Copy link
Collaborator

SanjalKatiyar commented Oct 9, 2024

PR #1598 added a hook useUserSettingsLocalStorage which provides access to localStorage, need to add an optional prop for sessionStorage as well.
ex: https://github.com/openshift/console/blob/master/frontend/packages/console-shared/src/hooks/useUserSettingsLocalStorage.ts

Note: we can talk to OCP team and get this hook exposed as part of SDK as well, instead of copying it on our end.

@SanjalKatiyar
Copy link
Collaborator Author

cc @GowthamShanmugam @bipuladh

@GowthamShanmugam
Copy link
Contributor

Console issue link: openshift/console#14393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants