Add lat/long to Request model, rework ID implementation #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @frankduncan. I responded to your questions re Google Maps API key in Zulip. See the thread here. I think I might have fixed the thing that was causing a problem -- I thought I had enabled geocoding and geolocation before, but it looks like I hadn't done it in the right way, and now I (hope I) have. |
Added a lookup on google maps API for requests coming in, which requires an API key to fulfill. Also fixes an infinite loop and changes the id creation mechanism.
frankduncan
force-pushed
the
issue-206
branch
from
7b57a10
to
cd9dd23
Compare
frankduncan
changed the title
|
@kfogel I've updated the description, and things are now working. Take a look when you have a chance :) |
cecilia-donnelly
approved these changes
Nov 5, 2018
There was a problem hiding this comment.
Works great, including finding the lat/long! Thanks @frankduncan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a working PR that imports the changes from #221.
Adds latitude/longitude to DB and does a geocode lookup from google maps api to get the location and put in database.
Of note is that the code to loop over serial's was removed to prevent an infinite loop (#159), but doesn't seem to be replaced with anything preventing duplicate serials as using shortid's was found not to be optimal.
Not sure what the solution here is, since this will come up as a race condition.