Remove pylint

Makefile

@@ -59,7 +59,6 @@ fmt: .venv
 lint: .venv
 	.venv/bin/ruff check
 	.venv/bin/ruff format --check
-	PYTHONPATH=. .venv/bin/pylint baseplate/
 	.venv/bin/mypy baseplate/
 
 .PHONY: checks

baseplate/__init__.py

@@ -212,7 +212,6 @@ def __getattr__(self, name: str) -> Any:
         return obj
 
     # this is just here for type checking
-    # pylint: disable=useless-super-delegation
     def __setattr__(self, name: str, value: Any) -> None:
         super().__setattr__(name, value)
 
@@ -286,7 +285,6 @@ def register(self, observer: BaseplateObserver) -> None:
         """
         self.observers.append(observer)
 
-    # pylint: disable=cyclic-import
     def configure_observers(self) -> None:
         """Configure diagnostics observers based on application configuration.
 

baseplate/clients/cassandra.py

@@ -12,14 +12,14 @@
 )
 
 from cassandra.auth import PlainTextAuthProvider
-from cassandra.cluster import (  # pylint: disable=no-name-in-module
+from cassandra.cluster import (
     _NOT_SET,
     Cluster,
     ExecutionProfile,
     ResponseFuture,
     Session,
 )
-from cassandra.query import (  # pylint: disable=no-name-in-module
+from cassandra.query import (
     BoundStatement,
     PreparedStatement,
     SimpleStatement,
@@ -224,7 +224,6 @@ class CQLMapperContextFactory(CassandraContextFactory):
     def make_object_for_context(self, name: str, span: Span) -> "cqlmapper.connection.Connection":
         # Import inline so you can still use the regular Cassandra integration
         # without installing cqlmapper
-        # pylint: disable=redefined-outer-name
         import cqlmapper.connection
 
         session_adapter = super().make_object_for_context(name, span)
@@ -271,7 +270,7 @@ def wait_for_callbacks_result(self: ResponseFuture) -> Any:
             logger.warning("Cassandra metrics callback took too long. Some metrics may be lost.")
 
         if exc:
-            raise exc  # pylint: disable=E0702
+            raise exc
 
         return result
 

baseplate/clients/kombu.py

@@ -126,7 +126,7 @@ def deserialize(self, message: bytes) -> T:
         """Deserialize the message bytes into an object for consuming."""
 
 
-class KombuThriftSerializer(KombuSerializer[T]):  # pylint: disable=unsubscriptable-object
+class KombuThriftSerializer(KombuSerializer[T]):
     """Thrift object serializer for Kombu."""
 
     def __init__(

baseplate/clients/memcache/lib.py

@@ -34,9 +34,7 @@ class Flags:
     ZLIB = 1 << 3
 
 
-def decompress_and_load(  # pylint: disable=unused-argument
-    key: str, serialized: bytes, flags: int
-) -> Any:
+def decompress_and_load(key: str, serialized: bytes, flags: int) -> Any:
     """Deserialize data.
 
     This should be paired with
@@ -97,9 +95,7 @@ def make_dump_and_compress_fn(
     assert min_compress_length >= 0
     assert 0 <= compress_level <= 9
 
-    def dump_and_compress(  # pylint: disable=unused-argument
-        key: str, value: Any
-    ) -> tuple[bytes, int]:
+    def dump_and_compress(key: str, value: Any) -> tuple[bytes, int]:
         """Serialize a Python object in a way compatible with decompress_and_load().
 
         :param key: the memcached key.
@@ -147,9 +143,7 @@ class PickleFlags:
     ZLIB = 1 << 3
 
 
-def decompress_and_unpickle(  # pylint: disable=unused-argument
-    key: str, serialized: bytes, flags: int
-) -> Any:
+def decompress_and_unpickle(key: str, serialized: bytes, flags: int) -> Any:
     """Deserialize data stored by ``pylibmc``.
 
     .. warning:: This should only be used when sharing caches with applications
@@ -214,9 +208,7 @@ def make_pickle_and_compress_fn(
     assert min_compress_length >= 0
     assert 0 <= compress_level <= 9
 
-    def pickle_and_compress(  # pylint: disable=unused-argument
-        key: str, value: Any
-    ) -> tuple[bytes, int]:
+    def pickle_and_compress(key: str, value: Any) -> tuple[bytes, int]:
         """Serialize a Python object in a way compatible with decompress_and_unpickle().
 
         :param key: the memcached key.

baseplate/clients/redis.py

@@ -197,7 +197,6 @@ def make_object_for_context(self, name: str, span: Span) -> "MonitoredRedisConne
         )
 
 
-# pylint: disable=too-many-public-methods
 class MonitoredRedisConnection(redis.StrictRedis):
     """Redis connection that collects diagnostic information.
 
@@ -253,7 +252,6 @@ def execute_command(self, *args: Any, **kwargs: Any) -> Any:
                 REQUESTS_TOTAL.labels(**result_labels).inc()
                 LATENCY_SECONDS.labels(**result_labels).observe(perf_counter() - start_time)
 
-    # pylint: disable=arguments-renamed
     def pipeline(  # type: ignore
         self, name: str, transaction: bool = True, shard_hint: Optional[str] = None
     ) -> "MonitoredRedisPipeline":
@@ -299,7 +297,6 @@ def __init__(
         self.redis_client_name = redis_client_name
         super().__init__(connection_pool, response_callbacks, **kwargs)
 
-    # pylint: disable=arguments-differ
     def execute(self, **kwargs: Any) -> Any:
         with self.server_span.make_child(self.trace_name):
             success = "true"
@@ -375,9 +372,7 @@ def get(self, timeout: Optional[float] = None) -> bytes:
 
         return message
 
-    def put(  # pylint: disable=unused-argument
-        self, message: bytes, timeout: Optional[float] = None
-    ) -> None:
+    def put(self, message: bytes, timeout: Optional[float] = None) -> None:
         """Add a message to the queue.
 
         :param message: will be typecast to a string upon storage and will come

baseplate/clients/redis_cluster.py

@@ -211,7 +211,6 @@ def maybe_track_key_usage(self, args: list[str]) -> None:
 # Unfortunately this is not provide as-is so we combine two connection pool classes to provide
 # the desired behaviour.
 class ClusterWithReadReplicasBlockingConnectionPool(rediscluster.ClusterBlockingConnectionPool):
-    # pylint: disable=arguments-differ
     def get_node_by_slot(self, slot: int, read_command: bool = False) -> dict[str, Any]:
         """Get a node from the slot.
 
@@ -471,7 +470,6 @@ def execute_command(self, *args: Any, **kwargs: Any) -> Any:
 
         return res
 
-    # pylint: disable=arguments-differ
     def pipeline(self, name: str) -> "MonitoredClusterRedisPipeline":
         """Create a pipeline.
 
@@ -496,7 +494,6 @@ def transaction(self, *args: Any, **kwargs: Any) -> Any:
         raise NotImplementedError
 
 
-# pylint: disable=abstract-method
 class MonitoredClusterRedisPipeline(ClusterPipeline):
     def __init__(
         self,
@@ -522,7 +519,6 @@ def execute_command(self, *args: Any, **kwargs: Any) -> Any:
 
         return res
 
-    # pylint: disable=arguments-differ
     def execute(self, **kwargs: Any) -> Any:
         with self.server_span.make_child(self.trace_name):
             success = "true"

baseplate/clients/sqlalchemy.py

@@ -224,7 +224,6 @@ def make_object_for_context(self, name: str, span: Span) -> Engine | Session:
         engine = self.engine.execution_options(context_name=name, server_span=span)
         return engine
 
-    # pylint: disable=unused-argument, too-many-arguments
     def on_before_execute(
         self,
         conn: Connection,
@@ -262,7 +261,6 @@ def on_before_execute(
 
         return annotated_statement, parameters
 
-    # pylint: disable=unused-argument, too-many-arguments
     def on_after_execute(
         self,
         conn: Connection,

baseplate/clients/thrift.py

@@ -181,7 +181,6 @@ def predicate(x: Any) -> bool:
 class _PooledClientProxy:
     """A proxy which acts like a thrift client but uses a connection pool."""
 
-    # pylint: disable=too-many-arguments
     def __init__(
         self,
         client_cls: Any,

baseplate/frameworks/pyramid/__init__.py

@@ -301,7 +301,6 @@ def should_trust_edge_context_payload(self, request: Request) -> bool:
         return self.trust_headers
 
 
-# pylint: disable=too-many-ancestors
 class BaseplateRequest(RequestContext, pyramid.request.Request):
     def __init__(self, *args: Any, **kwargs: Any) -> None:
         context_config = kwargs.pop("context_config", None)

baseplate/frameworks/pyramid/csrf.py

@@ -11,7 +11,7 @@
 
 try:
     # ICSRFStoragePolicy was not added to Pyramid until version 1.9
-    from pyramid.interfaces import ICSRFStoragePolicy  # pylint: disable=no-name-in-module
+    from pyramid.interfaces import ICSRFStoragePolicy
 except ImportError:
     logger.error(
         "baseplate.frameworks.pyramid.csrf requires that you use a version of pyramid >= 1.9"

baseplate/frameworks/queue_consumer/kafka.py

@@ -22,7 +22,7 @@
 )
 
 if TYPE_CHECKING:
-    WorkQueue = queue.Queue[confluent_kafka.Message]  # pylint: disable=unsubscriptable-object
+    WorkQueue = queue.Queue[confluent_kafka.Message]
 else:
     WorkQueue = queue.Queue
 
@@ -347,14 +347,12 @@ def make_kafka_consumer(
                 topic in all_topics
             ), f"topic '{topic}' does not exist. maybe it's misspelled or on a different kafka cluster?"  # noqa: E501
 
-        # pylint: disable=unused-argument
         def log_assign(
             consumer: confluent_kafka.Consumer, partitions: list[confluent_kafka.TopicPartition]
         ) -> None:
             for topic_partition in partitions:
                 logger.info("assigned %s/%s", topic_partition.topic, topic_partition.partition)
 
-        # pylint: disable=unused-argument
         def log_revoke(
             consumer: confluent_kafka.Consumer, partitions: list[confluent_kafka.TopicPartition]
         ) -> None:
@@ -469,7 +467,6 @@ def build_message_handler(self) -> KafkaMessageHandler:
 
         self.message_handler_count += 1
 
-        # pylint: disable=unused-argument
         def commit_offset(
             context: RequestContext, data: Any, message: confluent_kafka.Message
         ) -> None:
@@ -542,7 +539,6 @@ class FastConsumerFactory(_BaseKafkaQueueConsumerFactory):
 
     """
 
-    # pylint: disable=unused-argument
     @staticmethod
     def _commit_callback(
         err: confluent_kafka.KafkaError, topic_partition_list: list[confluent_kafka.TopicPartition]

baseplate/frameworks/queue_consumer/kombu.py

@@ -73,7 +73,7 @@ class AmqpConsumerPrometheusLabels(NamedTuple):
 )
 
 if TYPE_CHECKING:
-    WorkQueue = queue.Queue[kombu.Message]  # pylint: disable=unsubscriptable-object
+    WorkQueue = queue.Queue[kombu.Message]
 else:
     WorkQueue = queue.Queue
 

baseplate/lib/_requests.py

@@ -18,7 +18,6 @@
 
 
 class _UNIXConnection(urllib3.connectionpool.HTTPConnection):
-    # pylint: disable=super-init-not-called
     def __init__(self, url: str):
         urllib3.connectionpool.HTTPConnection.__init__(self, "localhost")
         self.url = urllib.parse.urlparse(url)

baseplate/lib/config.py

@@ -1,4 +1,3 @@
-# pylint: disable=invalid-name
 """Configuration parsing and validation.
 
 This module provides ``parse_config`` which turns a dictionary of stringy keys
@@ -174,7 +173,7 @@ class EndpointConfiguration(NamedTuple):
 
     """
 
-    family: socket.AddressFamily  # pylint: disable=no-member
+    family: socket.AddressFamily
     address: Union[InternetAddress, str]
 
     def __str__(self) -> str:
@@ -236,7 +235,7 @@ def File(mode: str = "r") -> Callable[[str], IO]:  # noqa: D401
 
     def open_file(text: str) -> IO:
         try:
-            return open(text, mode=mode, encoding="UTF-8")  # pylint: disable=R1732
+            return open(text, mode=mode, encoding="UTF-8")
         except OSError:
             raise ValueError(f"could not open file: {text}")
 

baseplate/lib/crypto.py

@@ -94,7 +94,7 @@ class SignatureInfo(NamedTuple):
 
 def _compute_digest(secret_value: bytes, header: bytes, message: str) -> bytes:
     payload = header + message.encode("utf8")
-    digest = hmac.new(secret_value, payload, hashlib.sha256).digest()  # pylint: disable=no-member
+    digest = hmac.new(secret_value, payload, hashlib.sha256).digest()
     return digest
 
 
@@ -149,7 +149,7 @@ def validate_signature(secret: VersionedSecret, message: str, signature: bytes)
         version, expiration = _HEADER_FORMAT.unpack(header)
         if version != 1:
             raise ValueError
-        if len(signature_digest) != hashlib.sha256().digest_size:  # pylint: disable=no-member
+        if len(signature_digest) != hashlib.sha256().digest_size:
             raise ValueError
     except (struct.error, KeyError, binascii.Error, TypeError, ValueError):
         raise UnreadableSignatureError

baseplate/lib/file_watcher.py

@@ -182,7 +182,6 @@ def get_data_and_mtime(self) -> tuple[T, float]:
         if self._mtime < current_mtime:
             logger.debug("Loading %s.", self._path)
             try:
-                # pylint: disable=unspecified-encoding
                 with open(self._path, **self._open_options._asdict()) as f:
                     self._data = self._parser(f)
             except Exception as exc:

baseplate/lib/live_data/zookeeper.py

@@ -48,7 +48,6 @@ def zookeeper_client_from_config(
         },
     )
 
-    # pylint: disable=maybe-no-member
     cfg = full_cfg.zookeeper
 
     auth_data = []

baseplate/lib/metrics.py

@@ -217,7 +217,6 @@ class Batch(BaseClient):
 
     """
 
-    # pylint: disable=super-init-not-called
     def __init__(self, transport: Transport, namespace: bytes):
         self.transport = BufferedTransport(transport)
         self.namespace = namespace
@@ -590,7 +589,6 @@ def metrics_client_from_config(raw_config: config.RawConfig) -> Client:
         },
     )
 
-    # pylint: disable=maybe-no-member
     return make_client(
         namespace=cfg.metrics.namespace,
         endpoint=cfg.metrics.endpoint,

baseplate/lib/secrets.py

@@ -122,7 +122,6 @@ def parse_secrets_fetcher(data: dict[str, Any], secret_path: str = "") -> dict[s
         raise SecretNotFoundError(secret_path)
 
 
-# pylint: disable=unused-argument
 def parse_vault_csi(data: dict[str, Any], secret_path: str = "") -> dict[str, str]:
     return data["data"]
 
@@ -145,7 +144,7 @@ def __init__(
         timeout: Optional[int] = None,
         backoff: Optional[float] = None,
         parser: Optional[SecretParser] = None,
-    ):  # pylint: disable=super-init-not-called
+    ):
         self.parser = parser or parse_secrets_fetcher
         self._filewatcher = FileWatcher(path, json.load, timeout=timeout, backoff=backoff)
 
@@ -361,7 +360,7 @@ def make_object_for_context(self, name: str, span: Span) -> "SecretsStore":
 class _CachingSecretsStore(SecretsStore):
     """Lazily load and cache the parsed data until the server span ends."""
 
-    def __init__(self, filewatcher: FileWatcher, parser: SecretParser):  # pylint: disable=super-init-not-called
+    def __init__(self, filewatcher: FileWatcher, parser: SecretParser):
         self._filewatcher = filewatcher
         self.parser = parser
 
@@ -397,7 +396,7 @@ def __init__(
         self,
         path: str,
         parser: SecretParser,
-    ):  # pylint: disable=super-init-not-called
+    ):
         self.path = Path(path)
         self.parser = parser
         self.cache = {}

baseplate/lib/service_discovery.py

@@ -97,7 +97,6 @@ def get_backends(self) -> Sequence[Backend]:
 
         """
         try:
-            # pylint: disable=maybe-no-member
             return self._filewatcher.get_data().backends
         except WatchedFileNotAvailableError:
             return []
@@ -119,7 +118,6 @@ def get_backend(self) -> Backend:
         except WatchedFileNotAvailableError:
             inventory = None
 
-        # pylint: disable=maybe-no-member
         if not inventory or not inventory.lottery:
             raise NoBackendsAvailableError