Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debounce for live reload #26

Open
Krakabek opened this issue Jul 11, 2024 · 2 comments · May be fixed by #27
Open

Add debounce for live reload #26

Krakabek opened this issue Jul 11, 2024 · 2 comments · May be fixed by #27

Comments

@Krakabek
Copy link
Collaborator

Editing code live leads to many errors. We could add 1-2s debounce for the live reload to let user finish writing the code
@niedzielski
Copy link
Member

I believe you can tune this by adjusting the throttle on #setSrcSideEffects() of play-pen. there's also been discussion around adding a checkbox for enabling / disabling auto-play.

@Krakabek
Copy link
Collaborator Author

I think throttle would not let me achieve the intended behaviour, I think we should switch to debounce
Will prepare a PR, so we can see it in aciton

@Krakabek Krakabek linked a pull request Jul 16, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use debounce instead of throttle to avoid unnecessary re-renders reddit/play
2 participants
@niedzielski @Krakabek