Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint and sanity errors #55

Closed
swapdisk opened this issue Jan 12, 2024 · 6 comments
Closed

Lint and sanity errors #55

swapdisk opened this issue Jan 12, 2024 · 6 comments

Comments

@swapdisk
Copy link
Member

With the release to Automation Hub, we see a number of (primarily formatting) errors from the ansible-lint test and sanity tests pep8, pylint, and shebang. See import log here.

Can we fix the offending code and also add these tests to our CI workflows?
@ygalblum
Copy link
Collaborator

Regarding the ansible-lint errors, we do run these checks. But, for some reason it seems that these tests disregard our yamllint configuration of indent-sequences: false defined here. What's strange here is that it does seem to pick the space indent configuration of 2

@ygalblum
Copy link
Collaborator

Regarding the shebang issues, please see ansible/ansible#78346

@ygalblum
Copy link
Collaborator

ygalblum commented Jan 14, 2024 •
edited
Loading

Regarding pylint, we also run it in our CI. Not sure why their run complains on something ours doesn't

@ygalblum
Copy link
Collaborator

We can add pep8 test to our CI

@ygalblum
Copy link
Collaborator

PyCodeStyle (pep8) is added to the CI #56

@swapdisk
Copy link
Member Author

swapdisk commented Feb 9, 2024

I'm calling this resolved.

@swapdisk swapdisk closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ygalblum @swapdisk