Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odo panics when overriding parent:components:attributes:pod-overrides:spec:imagePullSecrets:name #7099

Open
AgentK9 opened this issue Sep 26, 2023 · 7 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo)

Comments

@AgentK9
Copy link

AgentK9 commented Sep 26, 2023

/kind bug

What versions of software are you using?

Operating System: N/A (reproduced on windows and MacOS, but independent of OS or k8s back end)

Output of odo version: v3.14.0

How did you run odo exactly?

brew install odo, odo dev.

This may be an issue with the devfile library, unsure.

Actual behavior

See here for error message

Expected behavior

No error. odo dev runs as expected

Any logs, error output, etc?

See POC repo here

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 26, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Sep 26, 2023
@rm3l
Copy link
Member

rm3l commented Sep 27, 2023

Hi @AgentK9!

Thanks for reporting the issue and providing a sample repro repo.
FYI, the attribute for overriding properties of the pod spec is pod-overrides, not pod-override. Anyway, even with that, the issue was still there.
From the stacktrace, it looks like an issue with how the Devfile library merges complex attributes when handling a parent-child relationship.
I'll report this to the Devfile library repo, and when it is fixed there, we'll need to update odo accordingly.

/status blocked
EDIT: Blocked by devfile/api#1268

@rm3l rm3l added status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) and removed needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. labels Sep 27, 2023
@AgentK9 AgentK9 changed the title Odo panics when overriding parent:components:attributes:pod-override:spec:imagePullSecrets:name Odo panics when overriding parent:components:attributes:pod-overrides:spec:imagePullSecrets:name Sep 28, 2023
@AgentK9
Copy link
Author

AgentK9 commented Sep 28, 2023

Awesome! Thanks for the quick response. Edited the title to reflect your comment. Hope this gets resolved soon!

Copy link
Contributor

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2023
Copy link
Contributor

This issue was closed because it has been inactive for 30 days since being marked as stale.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 28, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 28, 2024
@github-project-automation github-project-automation bot moved this to Done ✅ in odo Project Jan 28, 2024
@AgentK9
Copy link
Author

AgentK9 commented Feb 1, 2024

Still an issue!

@rm3l
Copy link
Member

rm3l commented Feb 2, 2024

Still an issue!

Reopening, but still blocked by devfile/api#1268

/reopen
/remove-lifecycle stale
/remove-lifecycle rotten

@openshift-ci openshift-ci bot reopened this Feb 2, 2024
Copy link

openshift-ci bot commented Feb 2, 2024

@rm3l: Reopened this issue.

In response to this:

Still an issue!

Reopening, but still blocked by devfile/api#1268

/reopen
/remove-lifecycle stale
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Feb 2, 2024
@github-project-automation github-project-automation bot moved this from Done ✅ to To Do 📝 in odo Project Feb 2, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Feb 2, 2024
@rm3l rm3l removed the status in odo Project Feb 2, 2024
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Feb 2, 2024
@rm3l rm3l added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo)
Projects
Status: No status
Development

No branches or pull requests

2 participants