Ensure all disconnected annotations are accounted for when reviewing guidelines #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guidelines Signed-off-by: Jose R. Gonzalez <[email protected]>
openshift-ci
bot
added
the
approved
skattoju
approved these changes
Dec 18, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcrochet, komish, skattoju The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added support for new annotations for various infrastructure features, including disconnected/restricted network support, but our informational check that reviews the CSV's implementation of the guidelines for disconnected support was not accounting for the new annotation.
As a result, we'd emit logs indicating that "this operator didn't support deployment into environments with restricted networks" even if the new annotation was present, which was misleading.
This PR properly checks both annotations, and in the presence of either with a value indicating support for deployment into these environments, executes the logic to see how closely the maintainer adheres to the guidelines.
This also adds relevant tests, and relabels/documents the older annotation as "legacy".