Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root span is not created #99

Open
apaladiychuk opened this issue Oct 7, 2024 · 1 comment
Open

root span is not created #99

apaladiychuk opened this issue Oct 7, 2024 · 1 comment
Labels
needs investigation It looks as though have all the information needed but investigation is required observability A bug relating to observability components (metrics, logging, tracing, etc)

Comments

@apaladiychuk
Copy link

root span issue in benthos stream without defined input.
root span is not created when I run benthos stream using production function from my source code .
Please take a look on test envieronment that I create for reproduce this issue

https://github.com/apaladiychuk/benthos-issue

@mihaitodor mihaitodor added needs investigation It looks as though have all the information needed but investigation is required observability A bug relating to observability components (metrics, logging, tracing, etc) labels Oct 14, 2024
@mihaitodor
Copy link
Collaborator

Hey @apaladiychuk 👋 Sorry for the late reply. I just took a look at your code and I'm not sure why you're using a instead of a custom input. If you can replace that with a custom input, then you can call WrapBatchInputExtractTracingSpanMapping() which should do the trick. This API is used by the kafka input: https://github.com/redpanda-data/connect/blob/df39acca2d1788f6d1d444e7a3f7b6a4acf1ac94/internal/impl/kafka/input_sarama_kafka.go#L176.

There's also WrapInputExtractTracingSpanMapping() in case you don't need a batched input.

And there's also the matching WrapBatchOutputExtractTracingSpanMapping() and WrapOutputExtractTracingSpanMapping() for outputs if you wish to extract the tracing spans from the consumed message and merge them into the written result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation It looks as though have all the information needed but investigation is required observability A bug relating to observability components (metrics, logging, tracing, etc)
Projects
None yet
Development

No branches or pull requests

2 participants