Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update immer to v5 #240

Closed
wants to merge 1 commit into from
Closed

update immer to v5 #240

wants to merge 1 commit into from

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Oct 30, 2019

it might be better to let this rest for a week or so

Immer v5 was released today, with support for Map and Set.
While I believe it is usually adviced against using those in Redux, I also know that people do so anyways - those might benefit from this update.

On the other hand, this will bump the size of the immer dependency from gzipped 4.5kb to 6.3kb. ( https://bundlephobia.com/[email protected] ).

There is immerjs/immer#449 which aims to reduce bundle size again, and this is very new, so it might be a good idea to monitor immerjs/immer#354 if any other issues arise and decide on merging this in a week or two, so this PR is more of a reminder to check back later ;)

@netlify
Copy link

netlify bot commented Oct 30, 2019

Deploy preview for redux-starter-kit-docs ready!

Built with commit de88d36

https://deploy-preview-240--redux-starter-kit-docs.netlify.com

@markerikson
Copy link
Collaborator

The biggest issue here is that our serialization check middleware will explicitly throw errors if it sees a Map or Set in the state or action. So, this doesn't really buy us anything useful.

I'm not opposed to updating eventually, but that selling point doesn't help here.

@phryneas
Copy link
Member Author

phryneas commented Oct 30, 2019

Good point, hadn't thought of that! Guess we'll have no use at all from immer v5 at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants